[RAC] Persistent timeline fields fix (#110685)

* fix stringify circular ref crash and default columns on createTimeline * rollback reset buton fix to split PR * adding fields to the storage cleaning * tests fixed * test fix
elastic · Sep 2, 2021 · 56669c0 · 56669c0
1 parent f21731f
commit 56669c0
Show file tree

Hide file tree

Showing 11 changed files with 114 additions and 29 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/mock/global_state.ts b/x-pack/plugins/security_solution/public/common/mock/global_state.ts
@@ -242,6 +242,9 @@ export const mockGlobalState: State = {
         activeTab: TimelineTabs.query,
         prevActiveTab: TimelineTabs.notes,
         deletedEventIds: [],
+        documentType: '',
+        queryFields: [],
+        selectAll: false,
         id: 'test',
         savedObjectId: null,
         columns: defaultHeaders,

diff --git a/x-pack/plugins/security_solution/public/common/mock/timeline_results.ts b/x-pack/plugins/security_solution/public/common/mock/timeline_results.ts
@@ -1979,6 +1979,7 @@ export const mockTimelineModel: TimelineModel = {
   },
   deletedEventIds: [],
   description: 'This is a sample rule description',
+  documentType: '',
   eqlOptions: {
     eventCategoryField: 'event.category',
     tiebreakerField: 'event.sequence',
@@ -2017,13 +2018,15 @@ export const mockTimelineModel: TimelineModel = {
   kqlQuery: {
     filterQuery: null,
   },
+  queryFields: [],
   itemsPerPage: 25,
   itemsPerPageOptions: [10, 25, 50, 100],
   loadingEventIds: [],
   noteIds: [],
   pinnedEventIds: {},
   pinnedEventsSaveObject: {},
   savedObjectId: 'ef579e40-jibber-jabber',
+  selectAll: false,
   selectedEventIds: {},
   show: false,
   showCheckboxes: false,
@@ -2110,6 +2113,7 @@ export const defaultTimelineProps: CreateTimelineProps = {
     dateRange: { end: '2018-11-05T19:03:25.937Z', start: '2018-11-05T18:58:25.937Z' },
     deletedEventIds: [],
     description: '',
+    documentType: '',
     eqlOptions: {
       eventCategoryField: 'event.category',
       query: '',
@@ -2141,7 +2145,9 @@ export const defaultTimelineProps: CreateTimelineProps = {
     noteIds: [],
     pinnedEventIds: {},
     pinnedEventsSaveObject: {},
+    queryFields: [],
     savedObjectId: null,
+    selectAll: false,
     selectedEventIds: {},
     show: false,
     showCheckboxes: false,

diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.test.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_table/actions.test.tsx
@@ -148,6 +148,7 @@ describe('alert actions', () => {
             },
             deletedEventIds: [],
             description: 'This is a sample rule description',
+            documentType: '',
             eqlOptions: {
               eventCategoryField: 'event.category',
               query: '',
@@ -204,7 +205,9 @@ describe('alert actions', () => {
             noteIds: [],
             pinnedEventIds: {},
             pinnedEventsSaveObject: {},
+            queryFields: [],
             savedObjectId: null,
+            selectAll: false,
             selectedEventIds: {},
             show: true,
             showCheckboxes: false,

diff --git a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.test.ts b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.test.ts
@@ -296,6 +296,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -328,7 +329,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -366,6 +369,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -398,7 +402,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -436,6 +442,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -468,7 +475,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -504,6 +513,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -536,7 +546,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -577,6 +589,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -612,6 +625,8 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -680,6 +695,7 @@ describe('helpers', () => {
         dateRange: { start: '2020-07-07T08:20:18.966Z', end: '2020-07-08T08:20:18.966Z' },
         dataProviders: [],
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -758,6 +774,8 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -791,6 +809,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { end: '2020-10-28T11:37:31.655Z', start: '2020-10-27T11:37:31.655Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -823,7 +842,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,
@@ -861,6 +882,7 @@ describe('helpers', () => {
         dataProviders: [],
         dateRange: { end: '2020-07-08T08:20:18.966Z', start: '2020-07-07T08:20:18.966Z' },
         description: '',
+        documentType: '',
         deletedEventIds: [],
         eqlOptions: {
           eventCategoryField: 'event.category',
@@ -893,7 +915,9 @@ describe('helpers', () => {
         noteIds: [],
         pinnedEventIds: {},
         pinnedEventsSaveObject: {},
+        queryFields: [],
         savedObjectId: 'savedObject-1',
+        selectAll: false,
         selectedEventIds: {},
         show: false,
         showCheckboxes: false,