fixed some more missed anys

elastic · Apr 23, 2020 · 5565c98 · 5565c98
1 parent 8a7e27c
commit 5565c98
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 14 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/slack.test.ts b/x-pack/plugins/actions/server/builtin_action_types/slack.test.ts
@@ -155,10 +155,12 @@ describe('execute()', () => {
       params: { message: 'this invocation should succeed' },
     });
     expect(response).toMatchInlineSnapshot(`
-Object {
-  "text": "slack mockExecutor success: this invocation should succeed",
-}
-`);
+      Object {
+        "actionId": "",
+        "status": "ok",
+        "text": "slack mockExecutor success: this invocation should succeed",
+      }
+    `);
   });
 
   test('calls the mock executor with failure', async () => {

diff --git a/x-pack/plugins/alerting/server/alerts_client.test.ts b/x-pack/plugins/alerting/server/alerts_client.test.ts
@@ -5,7 +5,7 @@
  */
 import uuid from 'uuid';
 import { schema } from '@kbn/config-schema';
-import { AlertsClient } from './alerts_client';
+import { AlertsClient, CreateOptions } from './alerts_client';
 import { savedObjectsClientMock, loggingServiceMock } from '../../../../src/core/server/mocks';
 import { taskManagerMock } from '../../../plugins/task_manager/server/task_manager.mock';
 import { alertTypeRegistryMock } from './alert_type_registry.mock';
@@ -45,6 +45,7 @@ beforeEach(() => {
 });
 
 const mockedDate = new Date('2019-02-12T21:01:22.479Z');
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 (global as any).Date = class Date {
   constructor() {
     return mockedDate;
@@ -54,7 +55,7 @@ const mockedDate = new Date('2019-02-12T21:01:22.479Z');
   }
 };
 
-function getMockData(overwrites: Record<string, any> = {}) {
+function getMockData(overwrites: Record<string, unknown> = {}): CreateOptions['data'] {
   return {
     enabled: true,
     name: 'abc',

diff --git a/x-pack/plugins/alerting/server/alerts_client.ts b/x-pack/plugins/alerting/server/alerts_client.ts
@@ -84,7 +84,7 @@ export interface FindResult {
   data: SanitizedAlert[];
 }
 
-interface CreateOptions {
+export interface CreateOptions {
   data: Omit<
     Alert,
     | 'id'

diff --git a/x-pack/plugins/alerting/server/alerts_client_factory.test.ts b/x-pack/plugins/alerting/server/alerts_client_factory.test.ts
@@ -133,7 +133,7 @@ test('createAPIKey() returns an API key when security is enabled', async () => {
   const createAPIKeyResult = await constructorCall.createAPIKey();
   expect(createAPIKeyResult).toEqual({
     apiKeysEnabled: true,
-    result: { api_key: '123', id: 'abc' },
+    result: { api_key: '123', id: 'abc', name: '' },
   });
 });
 

diff --git a/x-pack/plugins/alerting/server/task_runner/get_next_run_at.test.ts b/x-pack/plugins/alerting/server/task_runner/get_next_run_at.test.ts
@@ -7,6 +7,7 @@
 import { getNextRunAt } from './get_next_run_at';
 
 const mockedNow = new Date('2019-06-03T18:55:25.982Z');
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 (global as any).Date = class Date extends global.Date {
   static now() {
     return mockedNow.getTime();

diff --git a/x-pack/plugins/task_manager/server/task_runner.test.ts b/x-pack/plugins/task_manager/server/task_runner.test.ts
@@ -854,8 +854,8 @@ describe('TaskManagerRunner', () => {
 
   interface TestOpts {
     instance?: Partial<ConcreteTaskInstance>;
-    definitions?: any;
-    onTaskEvent?: (event: TaskEvent<any, any>) => void;
+    definitions?: unknown;
+    onTaskEvent?: (event: TaskEvent<unknown, unknown>) => void;
   }
 
   function testOpts(opts: TestOpts) {
@@ -904,7 +904,7 @@ describe('TaskManagerRunner', () => {
           title: 'Bar!',
           createTaskRunner,
         },
-      }),
+      }) as TaskDictionary<TaskDefinition>,
       onTaskEvent: opts.onTaskEvent,
     });
 
@@ -918,7 +918,7 @@ describe('TaskManagerRunner', () => {
     };
   }
 
-  async function testReturn(result: any, shouldBeValid: boolean) {
+  async function testReturn(result: unknown, shouldBeValid: boolean) {
     const { runner, logger } = testOpts({
       definitions: {
         bar: {
@@ -939,11 +939,11 @@ describe('TaskManagerRunner', () => {
     }
   }
 
-  function allowsReturnType(result: any) {
+  function allowsReturnType(result: unknown) {
     return testReturn(result, true);
   }
 
-  function disallowsReturnType(result: any) {
+  function disallowsReturnType(result: unknown) {
     return testReturn(result, false);
   }
 });