-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* Fix main search bar to top of screen By allowing overflow on the main content, we implicitly fix the sibling search bar in position. elastic/code#1606 * Allow search suggestion text to be truncated This gives the parent element a width, so that our text-overflow rules apply to these elements. See https://bugzilla.mozilla.org/show_bug.cgi?id=1086218#c4 for details on the issue. * Fix alignment issue with overflowed search suggestions If both the icon and the text are allowed to grow/shrink as needed, flexbox will grow truncated text based on its original width, leading to subtle sub-pixel alignment issues with other rows. By fixing the icon to a specific width, we can ensure that the suggestion text does not grow too big. * Remove unneeded CSS We don't need to flex these elements currently as they contain either no children or inline elements only. * style: prefer camelCase element names over hyphens * Fix search result suggestion overflow on IE Without this directive on the parent, it had no width or flex growth and didn't respect the parent width. This allows it to take on the correct flexed width, and thus take on the overflow rules. * Remove unused CSS rule We have an overriding align-items declaration immediately after this one.
- Loading branch information
Showing
5 changed files
with
29 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 9 additions & 3 deletions
12
...omponents/query_bar/components/typeahead/__snapshots__/suggestion_component.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
16 changes: 12 additions & 4 deletions
16
...mponents/query_bar/components/typeahead/__snapshots__/suggestions_component.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
} | ||
|
||
.codeContainer__adminMain { | ||
overflow: auto; | ||
padding: $euiSize $euiSizeXL; | ||
} | ||
|
||
|