refactor(metrics): use indexPattern for PATCH request payload only

elastic · Nov 28, 2022 · 506cf6a · 506cf6a
1 parent a998397
commit 506cf6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/x-pack/plugins/infra/common/metrics_sources/index.ts b/x-pack/plugins/infra/common/metrics_sources/index.ts
@@ -29,11 +29,15 @@ export type MetricsSourceConfigurationProperties = rt.TypeOf<
   typeof metricsSourceConfigurationPropertiesRT
 >;
 
-export const partialMetricsSourceConfigurationPropertiesRT = rt.partial({
+export const partialMetricsSourceConfigurationReqPayloadRT = rt.partial({
   ...metricsSourceConfigurationPropertiesRT.type.props,
   metricAlias: indexPatternRt,
 });
 
+export const partialMetricsSourceConfigurationPropertiesRT = rt.partial({
+  ...metricsSourceConfigurationPropertiesRT.type.props,
+});
+
 export type PartialMetricsSourceConfigurationProperties = rt.TypeOf<
   typeof partialMetricsSourceConfigurationPropertiesRT
 >;

diff --git a/x-pack/plugins/infra/server/routes/metrics_sources/index.ts b/x-pack/plugins/infra/server/routes/metrics_sources/index.ts
@@ -16,6 +16,7 @@ import {
   partialMetricsSourceConfigurationPropertiesRT,
   metricsSourceConfigurationResponseRT,
   MetricsSourceStatus,
+  partialMetricsSourceConfigurationReqPayloadRT,
 } from '../../../common/metrics_sources';
 
 export const initMetricsSourceConfigurationRoutes = (libs: InfraBackendLibs) => {
@@ -73,7 +74,7 @@ export const initMetricsSourceConfigurationRoutes = (libs: InfraBackendLibs) =>
         params: schema.object({
           sourceId: schema.string(),
         }),
-        body: createValidationFunction(partialMetricsSourceConfigurationPropertiesRT),
+        body: createValidationFunction(partialMetricsSourceConfigurationReqPayloadRT),
       },
     },
     framework.router.handleLegacyErrors(async (requestContext, request, response) => {