Skip to content

Commit

Permalink
Revert implementation of POST /api/beats/configuration_blocks API (#…
Browse files Browse the repository at this point in the history
…19340)

This API allowed the user to operate at a level of abstraction that is unnecessarily and dangerously too low. A better API would be at one level higher, where users can create, update, and delete tags (where a tag can contain multiple configuration blocks).
  • Loading branch information
ycombinator authored and mattapperson committed Aug 7, 2018
1 parent 743ee67 commit 4e3ef15
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 257 deletions.
2 changes: 0 additions & 2 deletions x-pack/plugins/beats/server/routes/api/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ import { registerEnrollBeatRoute } from './register_enroll_beat_route';
import { registerListBeatsRoute } from './register_list_beats_route';
import { registerVerifyBeatsRoute } from './register_verify_beats_route';
import { registerUpdateBeatRoute } from './register_update_beat_route';
import { registerCreateConfigurationBlockRoute } from './register_create_configuration_block_route';

export function registerApiRoutes(server) {
registerCreateEnrollmentTokensRoute(server);
registerEnrollBeatRoute(server);
registerListBeatsRoute(server);
registerVerifyBeatsRoute(server);
registerUpdateBeatRoute(server);
registerCreateConfigurationBlockRoute(server);
}

This file was deleted.

149 changes: 0 additions & 149 deletions x-pack/test/api_integration/apis/beats/create_configuration_block.js

This file was deleted.

1 change: 0 additions & 1 deletion x-pack/test/api_integration/apis/beats/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ export default function ({ getService, loadTestFile }) {
loadTestFile(require.resolve('./list_beats'));
loadTestFile(require.resolve('./verify_beats'));
loadTestFile(require.resolve('./update_beat'));
loadTestFile(require.resolve('./create_configuration_block'));
});
}

0 comments on commit 4e3ef15

Please sign in to comment.