Skip to content

Commit

Permalink
[Security Solution] Update text and Response Console product name (#1…
Browse files Browse the repository at this point in the history
…38549) (#138621)

(cherry picked from commit 7cb83df)

Co-authored-by: Kevin Logan <[email protected]>
  • Loading branch information
kibanamachine and kevinlog authored Aug 11, 2022
1 parent c9743fe commit 4afe80f
Show file tree
Hide file tree
Showing 10 changed files with 22 additions and 26 deletions.
1 change: 1 addition & 0 deletions packages/kbn-doc-links/src/get_doc_links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ export const getDocLinks = ({ kibanaBranch }: GetDocLinkOptions): DocLinks => {
macos_system_ext: `${SECURITY_SOLUTION_DOCS}deploy-elastic-endpoint.html#system-extension-endpoint`,
linux_deadlock: `${SECURITY_SOLUTION_DOCS}ts-management.html`,
},
responseActions: `${SECURITY_SOLUTION_DOCS}response-actions.html`,
},
query: {
eql: `${ELASTICSEARCH_DOCS}eql.html`,
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-doc-links/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ export interface DocLinks {
linux_deadlock: string;
};
readonly threatIntelInt: string;
readonly responseActions: string;
};
readonly query: {
readonly eql: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const ResponderContextMenuItem = memo<ResponderContextMenuItemProps>(
>
<FormattedMessage
id="xpack.securitySolution.endpoint.detections.takeAction.responseActionConsole.buttonLabel"
defaultMessage="Launch responder"
defaultMessage="Respond"
/>
</EuiContextMenuItem>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,11 @@ describe('take action dropdown', () => {
);
});
});
test('should render "Launch responder"', async () => {
test('should render "Respond"', async () => {
await waitFor(() => {
expect(
wrapper.find('[data-test-subj="endpointResponseActions-action-item"]').first().text()
).toEqual('Launch responder');
).toEqual('Respond');
});
});
});
Expand Down Expand Up @@ -366,7 +366,7 @@ describe('take action dropdown', () => {
});
});

describe('should correctly enable/disable the "Launch responder" button', () => {
describe('should correctly enable/disable the "Respond" button', () => {
let wrapper: ReactWrapper;
let apiMocks: ReturnType<typeof endpointMetadataHttpMocks>;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { useConsoleStateDispatch } from '../hooks/state_selectors/use_console_st
import { COMMON_ARGS, HELP_GROUPS } from '../service/builtin_commands';
import { getCommandNameWithArgs } from '../service/utils';
import { ConsoleCodeBlock } from './console_code_block';
import { useKibana } from '../../../../common/lib/kibana';

// @ts-expect-error TS2769
const StyledEuiBasicTable = styled(EuiBasicTable)`
Expand Down Expand Up @@ -74,6 +75,7 @@ export interface CommandListProps {
export const CommandList = memo<CommandListProps>(({ commands, display = 'default' }) => {
const getTestId = useTestIdGenerator(useDataTestSubj());
const dispatch = useConsoleStateDispatch();
const { docLinks } = useKibana().services;

const footerMessage = useMemo(() => {
return (
Expand Down Expand Up @@ -228,21 +230,21 @@ export const CommandList = memo<CommandListProps>(({ commands, display = 'defaul
const calloutItems = [
<FormattedMessage
id="xpack.securitySolution.console.commandList.callout.multipleResponses"
defaultMessage="You may enter multiple response actions at the same time."
defaultMessage="You can enter consecutive response actions — no need to wait for previous actions to complete."
/>,
<FormattedMessage
id="xpack.securitySolution.console.commandList.callout.leavingResponder"
defaultMessage="Leaving the responder does not abort the actions."
defaultMessage="Leaving the response console does not terminate any actions that have been submitted."
/>,
<FormattedMessage
id="xpack.securitySolution.console.commandList.callout.visitSupportSections"
defaultMessage="{readMore} about manual response actions."
defaultMessage="{learnMore} about response actions and using the console."
values={{
readMore: (
<EuiLink>
learnMore: (
<EuiLink href={docLinks.links.securitySolution.responseActions} target="_blank">
<FormattedMessage
id="xpack.securitySolution.console.commandList.callout.readMoreLink"
defaultMessage="Read more"
defaultMessage="Learn more"
/>
</EuiLink>
),
Expand All @@ -255,17 +257,17 @@ export const CommandList = memo<CommandListProps>(({ commands, display = 'defaul
title={
<FormattedMessage
id="xpack.securitySolution.console.commandList.callout.title"
defaultMessage="Do you know?"
defaultMessage="Helpful tips:"
/>
}
>
<ol>
<ul>
{calloutItems.map((item, index) => (
<li key={index}>
<EuiText size="s">{item}</EuiText>
</li>
))}
</ol>
</ul>
</StyledEuiCallOut>
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,9 @@ export const SidePanelContentManager = memo(() => {
<EuiText size="s">
<FormattedMessage
id="xpack.securitySolution.console.sidePanel.helpDescription"
defaultMessage="To execute response actions {addText} ({icon}) use a comment or a parameter if necessary."
defaultMessage="Use the add ({icon}) button to populate a response action to the text bar. Add additional parameters or comments as necessary."
values={{
icon: <EuiIcon type="plusInCircle" />,
addText: (
<strong>
<FormattedMessage
id="xpack.securitySolution.console.sidePanel.helpDescription.addText"
defaultMessage="add to main text bar"
/>
</strong>
),
}}
/>
</EuiText>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const ActionLogButton = memo<EndpointResponderExtensionComponentProps>((p
>
<FormattedMessage
id="xpack.securitySolution.actionLogButton.label"
defaultMessage="Action log"
defaultMessage="Actions log"
/>
</EuiButton>
{showActionLogFlyout && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const TABLE_COLUMN_NAMES = Object.freeze({
export const UX_MESSAGES = Object.freeze({
flyoutTitle: (hostname: string) =>
i18n.translate('xpack.securitySolution.responseActionsList.flyout.title', {
defaultMessage: `Action log : {hostname}`,
defaultMessage: `Actions log : {hostname}`,
values: { hostname },
}),
pageTitle: i18n.translate('xpack.securitySolution.responseActionsList.list.title', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { OfflineCallout } from '../../components/endpoint_responder/offline_call
type ShowEndpointResponseActionsConsole = (endpointMetadata: HostMetadata) => void;

const RESPONDER_PAGE_TITLE = i18n.translate('xpack.securitySolution.responder_overlay.pageTitle', {
defaultMessage: 'Responder',
defaultMessage: 'Response console',
});

export const useWithShowEndpointResponder = (): ShowEndpointResponseActionsConsole => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const useEndpointActionItems = (
children: (
<FormattedMessage
id="xpack.securitySolution.endpoint.actions.console"
defaultMessage="Launch responder"
defaultMessage="Respond"
/>
),
toolTipContent: !isResponderCapabilitiesEnabled
Expand Down

0 comments on commit 4afe80f

Please sign in to comment.