Fix types check

elastic · May 8, 2024 · 4a577ef · 4a577ef
1 parent 0d8988e
commit 4a577ef
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/packages/kbn-json-tree/src/index.tsx b/packages/kbn-json-tree/src/index.tsx
@@ -20,7 +20,7 @@ export const JSONTree = ({
   data: Record<string, unknown>;
   isDarkMode: boolean;
   isSingleRow: boolean;
-  onTreeExpand: () => void;
+  onTreeExpand?: () => void;
 }) => {
   return (
     <>

diff --git a/packages/kbn-unified-data-table/src/components/data_table.tsx b/packages/kbn-unified-data-table/src/components/data_table.tsx
@@ -697,15 +697,17 @@ export const UnifiedDataTable = ({
 
   const toggleRowHeight = useCallback(
     (rowIndex: number) => {
-      // mimimize to single
-      if (autoHeightRows.includes(rowIndex)) {
-        setAutoHeightRows(autoHeightRows.filter((e) => e !== rowIndex));
-      } else {
-        // expand
-        setAutoHeightRows([...autoHeightRows, rowIndex]);
+      if (isPlainRecord) {
+        // mimimize to single row
+        if (autoHeightRows.includes(rowIndex)) {
+          setAutoHeightRows(autoHeightRows.filter((e) => e !== rowIndex));
+        } else {
+          // expand
+          setAutoHeightRows([...autoHeightRows, rowIndex]);
+        }
       }
     },
-    [autoHeightRows]
+    [autoHeightRows, isPlainRecord]
   );
 
   /**

diff --git a/packages/kbn-unified-data-table/src/components/source_document.tsx b/packages/kbn-unified-data-table/src/components/source_document.tsx
@@ -52,9 +52,9 @@ export function SourceDocument({
   fieldFormats: FieldFormatsStart;
   dataTestSubj?: string;
   className?: string;
-  isDarkMode: boolean;
-  isSingleRow: boolean;
-  onTreeExpand: () => void;
+  isDarkMode?: boolean;
+  isSingleRow?: boolean;
+  onTreeExpand?: () => void;
 }) {
   const pairs: FormattedHit = useTopLevelObjectColumns
     ? getTopLevelObjectPairs(row.raw, columnId, dataView, shouldShowFieldHandler).slice(
@@ -68,8 +68,8 @@ export function SourceDocument({
     return (
       <JSONTree
         data={row.raw as unknown as Record<string, unknown>}
-        isDarkMode={isDarkMode}
-        isSingleRow={isSingleRow}
+        isDarkMode={isDarkMode ?? false}
+        isSingleRow={isSingleRow ?? false}
         onTreeExpand={onTreeExpand}
       />
     );