[Defend Workflows] Rewrite visitRuleActions to make tests more stable (…

…#157691)
elastic · May 15, 2023 · 49c77f2 · 49c77f2
1 parent c322ac5
commit 49c77f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/...lugins/security_solution/public/management/cypress/e2e/mocked_data/response_actions.cy.ts b/...lugins/security_solution/public/management/cypress/e2e/mocked_data/response_actions.cy.ts
@@ -150,8 +150,7 @@ describe('Response actions', () => {
       cleanupRule(ruleId);
     });
 
-    // FLAKY: https://github.com/elastic/security-team/issues/6518
-    it.skip('All response action controls are disabled', () => {
+    it('All response action controls are disabled', () => {
       visitRuleActions(ruleId);
       cy.getByTestSubj('response-actions-wrapper').within(() => {
         cy.getByTestSubj('Endpoint Security-response-action-type-selection-option').should(

diff --git a/x-pack/plugins/security_solution/public/management/cypress/tasks/response_actions.ts b/x-pack/plugins/security_solution/public/management/cypress/tasks/response_actions.ts
@@ -50,15 +50,7 @@ export const fillUpNewRule = (name = 'Test', description = 'Test') => {
 export const visitRuleActions = (ruleId: string) => {
   cy.visit(`app/security/rules/id/${ruleId}/edit`);
   cy.getByTestSubj('edit-rule-actions-tab').should('exist');
-  // strange rerendering behaviour. the following make sure the test doesn't fail
-  cy.get('body').then(($body) => {
-    if ($body.find('[data-test-subj="globalLoadingIndicator"]').length) {
-      cy.getByTestSubj('globalLoadingIndicator').should('exist');
-      cy.getByTestSubj('globalLoadingIndicator').should('not.exist');
-    }
-    cy.getByTestSubj('globalLoadingIndicator').should('not.exist');
-  });
-
+  cy.getByTestSubj('globalLoadingIndicator').should('not.exist');
   cy.getByTestSubj('edit-rule-actions-tab').click();
 };
 export const tryAddingDisabledResponseAction = (itemNumber = 0) => {