[Maps] fix double fetch when filter pill is added (#63024) (#63529)

* [Maps] fix double fetch when filter pill is added * remove isDataSyncActive * set dataMetaAtStart to null instead of deleting Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elastic · Apr 14, 2020 · 497ea96 · 497ea96
1 parent e7285bb
commit 497ea96
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts b/x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts
@@ -65,7 +65,7 @@ export type DataMeta = Partial<VectorSourceRequestMeta> &
 
 export type DataRequestDescriptor = {
   dataId: string;
-  dataMetaAtStart?: DataMeta;
+  dataMetaAtStart?: DataMeta | null;
   dataRequestToken?: symbol;
   data?: object;
   dataMeta?: DataMeta;

diff --git a/x-pack/plugins/maps/public/layers/util/data_request.ts b/x-pack/plugins/maps/public/layers/util/data_request.ts
@@ -26,9 +26,13 @@ export class DataRequest {
   }
 
   getMeta(): DataMeta {
-    return this.hasData()
-      ? _.get(this._descriptor, 'dataMeta', {})
-      : _.get(this._descriptor, 'dataMetaAtStart', {});
+    if (this._descriptor.dataMetaAtStart) {
+      return this._descriptor.dataMetaAtStart;
+    } else if (this._descriptor.dataMeta) {
+      return this._descriptor.dataMeta;
+    } else {
+      return {};
+    }
   }
 
   hasData(): boolean {

diff --git a/x-pack/plugins/maps/public/reducers/map.js b/x-pack/plugins/maps/public/reducers/map.js
@@ -57,8 +57,13 @@ const updateLayerInList = (state, layerId, attribute, newValue) => {
   if (!layerId) {
     return state;
   }
+
   const { layerList } = state;
   const layerIdx = getLayerIndex(layerList, layerId);
+  if (layerIdx === -1) {
+    return state;
+  }
+
   const updatedLayer = {
     ...layerList[layerIdx],
     // Update layer w/ new value. If no value provided, toggle boolean value