fix types

elastic · May 19, 2021 · 48cce60 · 48cce60
1 parent 0fbfb75
commit 48cce60
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 18 deletions.
diff --git a/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts b/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts
@@ -109,3 +109,4 @@ export const ReportToDataTypeMap: Record<ReportViewTypeId, AppDataType> = {
 
 export const USE_BREAK_DOWN_COLUMN = 'USE_BREAK_DOWN_COLUMN';
 export const FILTER_RECORDS = 'FILTER_RECORDS';
+export const OPERATION_COLUMN = 'operation';
diff --git a/...ability/public/components/shared/exploratory_view/configurations/rum/kpi_trends_config.ts b/...ability/public/components/shared/exploratory_view/configurations/rum/kpi_trends_config.ts
@@ -6,7 +6,7 @@
  */
 
 import { ConfigProps, DataSeries } from '../../types';
-import { FieldLabels, RECORDS_FIELD } from '../constants';
+import { FieldLabels, OPERATION_COLUMN, RECORDS_FIELD } from '../constants';
 import { buildPhraseFilter } from '../utils';
 import {
   CLIENT_GEO_COUNTRY_NAME,
@@ -85,20 +85,25 @@ export function getKPITrendsLensConfig({ seriesId, indexPattern }: ConfigProps):
       {
         field: 'business.kpi',
         custom: true,
-        defaultValue: RECORDS_FIELD,
         options: [
-          { field: RECORDS_FIELD, label: PAGE_VIEWS_LABEL },
-          { label: PAGE_LOAD_TIME_LABEL, field: TRANSACTION_DURATION, columnType: 'operation' },
+          { field: RECORDS_FIELD, id: RECORDS_FIELD, label: PAGE_VIEWS_LABEL },
+          {
+            label: PAGE_LOAD_TIME_LABEL,
+            field: TRANSACTION_DURATION,
+            id: TRANSACTION_DURATION,
+            columnType: OPERATION_COLUMN,
+          },
           {
             label: BACKEND_TIME_LABEL,
             field: TRANSACTION_TIME_TO_FIRST_BYTE,
-            columnType: 'operation',
+            id: TRANSACTION_TIME_TO_FIRST_BYTE,
+            columnType: OPERATION_COLUMN,
           },
-          { label: FCP_LABEL, field: FCP_FIELD, columnType: 'operation' },
-          { label: TBT_LABEL, field: TBT_FIELD, columnType: 'operation' },
-          { label: LCP_LABEL, field: LCP_FIELD, columnType: 'operation' },
-          { label: FID_LABEL, field: FID_FIELD, columnType: 'operation' },
-          { label: CLS_LABEL, field: CLS_FIELD, columnType: 'operation' },
+          { label: FCP_LABEL, field: FCP_FIELD, id: FCP_FIELD, columnType: OPERATION_COLUMN },
+          { label: TBT_LABEL, field: TBT_FIELD, id: TBT_FIELD, columnType: OPERATION_COLUMN },
+          { label: LCP_LABEL, field: LCP_FIELD, id: LCP_FIELD, columnType: OPERATION_COLUMN },
+          { label: FID_LABEL, field: FID_FIELD, id: FID_FIELD, columnType: OPERATION_COLUMN },
+          { label: CLS_LABEL, field: CLS_FIELD, id: CLS_FIELD, columnType: OPERATION_COLUMN },
         ],
       },
     ],

diff --git a/...y/public/components/shared/exploratory_view/configurations/rum/performance_dist_config.ts b/...y/public/components/shared/exploratory_view/configurations/rum/performance_dist_config.ts
@@ -80,15 +80,18 @@ export function getPerformanceDistLensConfig({ seriesId, indexPattern }: ConfigP
       {
         field: 'performance.metric',
         custom: true,
-        defaultValue: TRANSACTION_DURATION,
         options: [
-          { label: PAGE_LOAD_TIME_LABEL, field: TRANSACTION_DURATION },
-          { label: BACKEND_TIME_LABEL, field: TRANSACTION_TIME_TO_FIRST_BYTE },
-          { label: FCP_LABEL, field: FCP_FIELD },
-          { label: TBT_LABEL, field: TBT_FIELD },
-          { label: LCP_LABEL, field: LCP_FIELD },
-          { label: FID_LABEL, field: FID_FIELD },
-          { label: CLS_LABEL, field: CLS_FIELD },
+          { label: PAGE_LOAD_TIME_LABEL, id: TRANSACTION_DURATION, field: TRANSACTION_DURATION },
+          {
+            label: BACKEND_TIME_LABEL,
+            id: TRANSACTION_TIME_TO_FIRST_BYTE,
+            field: TRANSACTION_TIME_TO_FIRST_BYTE,
+          },
+          { label: FCP_LABEL, id: FCP_FIELD, field: FCP_FIELD },
+          { label: TBT_LABEL, id: TBT_FIELD, field: TBT_FIELD },
+          { label: LCP_LABEL, id: LCP_FIELD, field: LCP_FIELD },
+          { label: FID_LABEL, id: FID_FIELD, field: FID_FIELD },
+          { label: CLS_LABEL, id: CLS_FIELD, field: CLS_FIELD },
         ],
       },
     ],
Original file line number	Diff line number	Diff line change
Expand Up		@@ -109,3 +109,4 @@ export const ReportToDataTypeMap: Record<ReportViewTypeId, AppDataType> = {

		export const USE_BREAK_DOWN_COLUMN = 'USE_BREAK_DOWN_COLUMN';
		export const FILTER_RECORDS = 'FILTER_RECORDS';
		export const OPERATION_COLUMN = 'operation';