change feature flag name and disable it by default

elastic · Apr 12, 2024 · 47eec14 · 47eec14
1 parent 5da233d
commit 47eec14
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/common/experimental_features.ts b/x-pack/plugins/security_solution/common/experimental_features.ts
@@ -237,7 +237,7 @@ export const allowedExperimentalValues = Object.freeze({
   /**
    * Enables the new modal for the value list items
    */
-  valueListItemsModal: true,
+  valueListItemsModalEnabled: false,
 });
 
 type ExperimentalConfigKeys = Array<keyof ExperimentalFeatures>;

diff --git a/x-pack/plugins/security_solution/public/value_list/components/show_value_list_modal.tsx b/x-pack/plugins/security_solution/public/value_list/components/show_value_list_modal.tsx
@@ -22,7 +22,7 @@ export const ShowValueListModal = ({
 }) => {
   const [showModal, setShowModal] = useState(false);
   const { canWriteIndex, canReadIndex, loading } = useListsPrivileges();
-  const isValueItemsListModalEnabled = useIsExperimentalFeatureEnabled('valueListItemsModal');
+  const isValueItemsListModalEnabled = useIsExperimentalFeatureEnabled('valueListItemsModalEnabled');
 
   const onCloseModal = useCallback(() => setShowModal(false), []);
   const onShowModal = useCallback(() => setShowModal(true), []);

diff --git a/...ypress/cypress/e2e/detection_response/detection_engine/value_lists/value_list_items.cy.ts b/...ypress/cypress/e2e/detection_response/detection_engine/value_lists/value_list_items.cy.ts
@@ -47,7 +47,9 @@ describe(
     env: {
       ftrConfig: {
         kbnServerArgs: [
-          `--xpack.securitySolution.enableExperimental=${JSON.stringify(['valueListItemsModal'])}`,
+          `--xpack.securitySolution.enableExperimental=${JSON.stringify([
+            'valueListItemsModalEnabled',
+          ])}`,
         ],
       },
     },