remove ALERT_SEVERITY_VALUE occurences, this value is not being read …

…and shown in the Observability alerts table
elastic · Aug 18, 2021 · 46b6201 · 46b6201
1 parent a64b656
commit 46b6201
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 20 deletions.
diff --git a/packages/kbn-rule-data-utils/src/technical_field_names.ts b/packages/kbn-rule-data-utils/src/technical_field_names.ts
@@ -32,8 +32,6 @@ const ALERT_ID = `${ALERT_NAMESPACE}.id` as const;
 const ALERT_REASON = `${ALERT_NAMESPACE}.reason` as const;
 const ALERT_RISK_SCORE = `${ALERT_NAMESPACE}.risk_score` as const;
 const ALERT_SEVERITY = `${ALERT_NAMESPACE}.severity` as const;
-const ALERT_SEVERITY = `${ALERT_NAMESPACE}.severity.level` as const;
-// const ALERT_SEVERITY_VALUE = `${ALERT_NAMESPACE}.severity.value` as const;
 const ALERT_START = `${ALERT_NAMESPACE}.start` as const;
 const ALERT_STATUS = `${ALERT_NAMESPACE}.status` as const;
 const ALERT_SYSTEM_STATUS = `${ALERT_NAMESPACE}.system_status` as const;
@@ -130,7 +128,6 @@ const fields = {
   ALERT_START,
   ALERT_SEVERITY,
   ALERT_SEVERITY,
-  // ALERT_SEVERITY_VALUE,
   ALERT_STATUS,
   ALERT_SYSTEM_STATUS,
   ALERT_UUID,
@@ -186,7 +183,6 @@ export {
   ALERT_RULE_VERSION,
   ALERT_RULE_SEVERITY,
   ALERT_SEVERITY,
-  // ALERT_SEVERITY_VALUE,
   ALERT_START,
   ALERT_SYSTEM_STATUS,
   ALERT_UUID,

diff --git a/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts b/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_anomaly_alert_type.ts
@@ -13,14 +13,12 @@ import type {
   ALERT_EVALUATION_THRESHOLD as ALERT_EVALUATION_THRESHOLD_TYPED,
   ALERT_EVALUATION_VALUE as ALERT_EVALUATION_VALUE_TYPED,
   ALERT_SEVERITY as ALERT_SEVERITY_TYPED,
-  // ALERT_SEVERITY_VALUE as ALERT_SEVERITY_VALUE_TYPED,
   ALERT_REASON as ALERT_REASON_TYPED,
 } from '@kbn/rule-data-utils';
 import {
   ALERT_EVALUATION_THRESHOLD as ALERT_EVALUATION_THRESHOLD_NON_TYPED,
   ALERT_EVALUATION_VALUE as ALERT_EVALUATION_VALUE_NON_TYPED,
   ALERT_SEVERITY as ALERT_SEVERITY_NON_TYPED,
-  // ALERT_SEVERITY_VALUE as ALERT_SEVERITY_VALUE_NON_TYPED,
   ALERT_REASON as ALERT_REASON_NON_TYPED,
   // @ts-expect-error
 } from '@kbn/rule-data-utils/target_node/technical_field_names';
@@ -52,7 +50,6 @@ import {
 const ALERT_EVALUATION_THRESHOLD: typeof ALERT_EVALUATION_THRESHOLD_TYPED = ALERT_EVALUATION_THRESHOLD_NON_TYPED;
 const ALERT_EVALUATION_VALUE: typeof ALERT_EVALUATION_VALUE_TYPED = ALERT_EVALUATION_VALUE_NON_TYPED;
 const ALERT_SEVERITY: typeof ALERT_SEVERITY_TYPED = ALERT_SEVERITY_NON_TYPED;
-// const ALERT_SEVERITY_VALUE: typeof ALERT_SEVERITY_VALUE_TYPED = ALERT_SEVERITY_VALUE_NON_TYPED;
 const ALERT_REASON: typeof ALERT_REASON_TYPED = ALERT_REASON_NON_TYPED;
 
 const paramsSchema = schema.object({

diff --git a/x-pack/plugins/observability/public/pages/alerts/example_data.ts b/x-pack/plugins/observability/public/pages/alerts/example_data.ts
@@ -10,7 +10,6 @@ import {
   ALERT_END,
   ALERT_ID,
   ALERT_SEVERITY,
-  // ALERT_SEVERITY_VALUE,
   ALERT_RULE_TYPE_ID,
   ALERT_START,
   ALERT_STATUS,
@@ -130,14 +129,6 @@ export const dynamicIndexPattern = {
       aggregatable: true,
       readFromDocValues: true,
     },
-    // {
-    //   name: 'ALERT_SEVERITY_VALUE',
-    //   type: 'number',
-    //   esTypes: ['long'],
-    //   searchable: true,
-    //   aggregatable: true,
-    //   readFromDocValues: true,
-    // },
     {
       name: ALERT_START,
       type: 'date',

diff --git a/x-pack/plugins/rule_registry/common/assets/field_maps/technical_rule_field_map.ts b/x-pack/plugins/rule_registry/common/assets/field_maps/technical_rule_field_map.ts
@@ -26,7 +26,6 @@ export const technicalRuleFieldMap = {
   [Fields.ALERT_END]: { type: 'date' },
   [Fields.ALERT_DURATION]: { type: 'long' },
   [Fields.ALERT_SEVERITY]: { type: 'keyword' },
-  // [Fields.ALERT_SEVERITY_VALUE]: { type: 'long' },
   [Fields.ALERT_STATUS]: { type: 'keyword' },
   [Fields.ALERT_EVALUATION_THRESHOLD]: { type: 'scaled_float', scaling_factor: 100 },
   [Fields.ALERT_EVALUATION_VALUE]: { type: 'scaled_float', scaling_factor: 100 },

diff --git a/x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts b/x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts
@@ -6,7 +6,6 @@
  */
 import {
   ALERT_SEVERITY,
-  // ALERT_SEVERITY_VALUE,
   ALERT_EVALUATION_VALUE,
   ALERT_EVALUATION_THRESHOLD,
   ALERT_REASON,

diff --git a/x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts b/x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts
@@ -9,7 +9,6 @@ import moment from 'moment';
 import { schema } from '@kbn/config-schema';
 import {
   ALERT_SEVERITY,
-  // ALERT_SEVERITY_VALUE,
   ALERT_EVALUATION_VALUE,
   ALERT_EVALUATION_THRESHOLD,
   ALERT_REASON,
@@ -136,7 +135,6 @@ export const durationAnomalyAlertFactory: UptimeAlertTypeFactory<ActionGroupIds>
             [ALERT_EVALUATION_VALUE]: anomaly.actualSort,
             [ALERT_EVALUATION_THRESHOLD]: anomaly.typicalSort,
             [ALERT_SEVERITY]: summary.severity,
-            // [ALERT_SEVERITY_VALUE]: summary.severityScore,
             [ALERT_REASON]: generateAlertMessage(
               CommonDurationAnomalyTranslations.defaultActionMessage,
               summary