Fixes in the merged PR

elastic · Sep 17, 2024 · 46005df · 46005df
1 parent e426631
commit 46005df
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 35 deletions.
diff --git a/packages/kbn-language-documentation-popover/src/components/as_flyout/index.tsx b/packages/kbn-language-documentation-popover/src/components/as_flyout/index.tsx
@@ -15,6 +15,7 @@ import {
   EuiTitle,
   EuiSpacer,
 } from '@elastic/eui';
+import { i18n } from '@kbn/i18n';
 import { getFilteredGroups } from '../../utils/get_filtered_groups';
 import { DocumentationMainContent, DocumentationNavigation } from '../shared';
 import { getESQLDocsSections } from '../../sections';
@@ -83,7 +84,11 @@ function DocumentationFlyout({
         >
           <EuiFlyoutHeader hasBorder>
             <EuiTitle size="s">
-              <h3>ES|QL quick reference</h3>
+              <h3>
+                {i18n.translate('languageDocumentationPopover.documentationFlyoutTitle', {
+                  defaultMessage: 'ES|QL quick reference',
+                })}
+              </h3>
             </EuiTitle>
             <EuiSpacer size="m" />
             <DocumentationNavigation

diff --git a/...ges/kbn-language-documentation-popover/src/components/shared/documentation_navigation.tsx b/...ges/kbn-language-documentation-popover/src/components/shared/documentation_navigation.tsx
@@ -43,39 +43,43 @@ function DocumentationNav({
     <>
       <EuiFlexGroup gutterSize="none" responsive={false} direction="column">
         <EuiFlexItem grow={true}>
-        <EuiFormRow
-          fullWidth
-          label="Select or search topics"
-          labelAppend={linkToDocumentation && (
-            <EuiText size="xs">
-              <EuiLink
-                external
-                href={linkToDocumentation}
-                target="_blank"
-                data-test-subj="language-documentation-navigation-link"
-              >
-                {i18n.translate('languageDocumentationPopover.esqlDocsLabel', {
-                  defaultMessage: 'View full ES|QL documentation',
-                })}
-              </EuiLink>
-            </EuiText>
-            )}
-          >
-          <EuiComboBox
-            aria-label={i18n.translate('languageDocumentationPopover.navigationAriaLabel', {
-              defaultMessage: 'Navigate through the documentation',
-            })}
-            placeholder={i18n.translate('languageDocumentationPopover.navigationPlaceholder', {
-              defaultMessage: 'Commands and functions',
-            })}
-            data-test-subj="language-documentation-navigation-dropdown"
-            options={filteredGroups}
-            selectedOptions={selectedSection ? [{ label: selectedSection }] : []}
-            singleSelection={{ asPlainText: true }}
-            onChange={onNavigationChange}
-            compressed
+          <EuiFormRow
             fullWidth
-          />
+            label={i18n.translate('languageDocumentationPopover.esqlDocsLabel', {
+              defaultMessage: 'Select or search topics',
+            })}
+            labelAppend={
+              linkToDocumentation && (
+                <EuiText size="xs">
+                  <EuiLink
+                    external
+                    href={linkToDocumentation}
+                    target="_blank"
+                    data-test-subj="language-documentation-navigation-link"
+                  >
+                    {i18n.translate('languageDocumentationPopover.esqlDocsLinkLabel', {
+                      defaultMessage: 'View full ES|QL documentation',
+                    })}
+                  </EuiLink>
+                </EuiText>
+              )
+            }
+          >
+            <EuiComboBox
+              aria-label={i18n.translate('languageDocumentationPopover.navigationAriaLabel', {
+                defaultMessage: 'Navigate through the documentation',
+              })}
+              placeholder={i18n.translate('languageDocumentationPopover.navigationPlaceholder', {
+                defaultMessage: 'Commands and functions',
+              })}
+              data-test-subj="language-documentation-navigation-dropdown"
+              options={filteredGroups}
+              selectedOptions={selectedSection ? [{ label: selectedSection }] : []}
+              singleSelection={{ asPlainText: true }}
+              onChange={onNavigationChange}
+              compressed
+              fullWidth
+            />
           </EuiFormRow>
         </EuiFlexItem>
         <EuiFlexItem

diff --git a/packages/kbn-language-documentation-popover/src/sections/esql_documentation_sections.tsx b/packages/kbn-language-documentation-popover/src/sections/esql_documentation_sections.tsx
@@ -18,8 +18,7 @@ const Markdown = (props: Parameters<typeof SharedUXMarkdown>[0]) => (
 export const initialSection = (
   <Markdown
     markdownContent={i18n.translate('languageDocumentationPopover.documentationESQL.markdown', {
-      defaultMessage: `## ES|QL
-
+      defaultMessage: `
 An ES|QL (Elasticsearch query language) query consists of a series of commands, separated by pipe characters: \`|\`. Each query starts with a **source command**, which produces a table, typically with data from Elasticsearch. 
 
 A source command can be followed by one or more **processing commands**. Processing commands can change the output table of the previous command by adding, removing, and changing rows and columns.