note about semantic html;

elastic · Aug 9, 2023 · 452e34f · 452e34f
1 parent 74f25d3
commit 452e34f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx
@@ -278,6 +278,11 @@ export const ProjectHeader = ({
             </EuiHeaderSection>
           </EuiHeader>
 
+          {/* NOTE: It would be better to house this content in a location closer to the main page content,
+          rather than in the header area. Using the header to mount this content offers the convenience of
+          consistency, but could create accessbility issues if screenreaders announce this content as if it
+          were part of the header. Semantically, AppMenuBar is not part of the header.
+          See: https://github.com/elastic/kibana/pull/162002#discussion_r1287468143 */}
           {headerActionMenuMounter.mount && (
             <AppMenuBar
               isOpen={isOpen ?? false}