second round of disabling rules on a per-line basis.

elastic · Jun 4, 2020 · 44fb7ef · 44fb7ef
1 parent 3e00900
commit 44fb7ef
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/x-pack/plugins/infra/public/components/alerting/inventory/expression.tsx b/x-pack/plugins/infra/public/components/alerting/inventory/expression.tsx
@@ -117,6 +117,7 @@ export const Expressions: React.FC<Props> = (props) => {
       timeUnit: timeUnit ?? defaultExpression.timeUnit,
     });
     setAlertParams('criteria', exp);
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [setAlertParams, alertParams.criteria, timeSize, timeUnit]);
 
   const removeExpression = useCallback(
@@ -141,6 +142,7 @@ export const Expressions: React.FC<Props> = (props) => {
     [derivedIndexPattern, setAlertParams]
   );
 
+  /* eslint-disable-next-line react-hooks/exhaustive-deps */
   const debouncedOnFilterChange = useCallback(debounce(onFilterChange, FILTER_TYPING_DEBOUNCE_MS), [
     onFilterChange,
   ]);

diff --git a/x-pack/plugins/infra/public/components/alerting/logs/expression_editor/editor.tsx b/x-pack/plugins/infra/public/components/alerting/logs/expression_editor/editor.tsx
@@ -137,6 +137,7 @@ export const Editor: React.FC<Props> = (props) => {
     } else {
       return [];
     }
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [sourceStatus]);
 
   const updateCount = useCallback(
@@ -176,6 +177,7 @@ export const Editor: React.FC<Props> = (props) => {
       ? [...alertParams.criteria, DEFAULT_CRITERIA]
       : [DEFAULT_CRITERIA];
     setAlertParams('criteria', nextCriteria);
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [alertParams, setAlertParams]);
 
   const removeCriterion = useCallback(
@@ -185,6 +187,7 @@ export const Editor: React.FC<Props> = (props) => {
       });
       setAlertParams('criteria', nextCriteria);
     },
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
     [alertParams, setAlertParams]
   );
 

diff --git a/x-pack/plugins/infra/public/components/header/header.tsx b/x-pack/plugins/infra/public/components/header/header.tsx
@@ -31,10 +31,12 @@ export const Header = ({ breadcrumbs = [], readOnlyBadge = false }: HeaderProps)
 
   const setBreadcrumbs = useCallback(() => {
     return chrome?.setBreadcrumbs(breadcrumbs || []);
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [breadcrumbs, chrome]);
 
   const setBadge = useCallback(() => {
     return chrome?.setBadge(badge);
+    /* eslint-disable-next-line react-hooks/exhaustive-deps */
   }, [badge, chrome]);
 
   useEffect(() => {