fix usafe of getEventLog

elastic · Nov 24, 2020 · 44886c5 · 44886c5
1 parent f0c2673
commit 44886c5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 11 deletions.
diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/execute.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/actions/execute.ts
@@ -518,12 +518,10 @@ export default function ({ getService }: FtrProviderContext) {
         type: 'action',
         id: actionId,
         provider: 'actions',
-        actions: ['execute'],
+        actions: new Map([['execute', { equal: 1 }]]),
       });
     });
 
-    expect(events.length).to.equal(1);
-
     const event = events[0];
 
     const duration = event?.event?.duration;

diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts
@@ -1096,12 +1096,10 @@ instanceStateValue: true
         type: 'alert',
         id: alertId,
         provider: 'alerting',
-        actions: ['execute'],
+        actions: new Map([['execute', { gte: 1 }]]),
       });
     });
 
-    expect(events.length).to.be.greaterThan(0);
-
     const event = events[0];
 
     const duration = event?.event?.duration;

diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/event_log.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/event_log.ts
@@ -56,7 +56,7 @@ export default function eventLogTests({ getService }: FtrProviderContext) {
           type: 'alert',
           id: alertId,
           provider: 'alerting',
-          actions: ['execute'],
+          actions: new Map([['execute', { gte: 1 }]]),
         });
         const errorEvents = someEvents.filter(
           (event) => event?.kibana?.alerting?.status === 'error'

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/actions/execute.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/actions/execute.ts
@@ -270,12 +270,10 @@ export default function ({ getService }: FtrProviderContext) {
         type: 'action',
         id: actionId,
         provider: 'actions',
-        actions: ['execute'],
+        actions: new Map([['execute', { equal: 1 }]]),
       });
     });
 
-    expect(events.length).to.equal(1);
-
     const event = events[0];
 
     const duration = event?.event?.duration;

diff --git a/...ck/test/alerting_api_integration/spaces_only/tests/alerting/get_alert_instance_summary.ts b/...ck/test/alerting_api_integration/spaces_only/tests/alerting/get_alert_instance_summary.ts
@@ -256,7 +256,7 @@ export default function createGetAlertInstanceSummaryTests({ getService }: FtrPr
         type: 'alert',
         id,
         provider: 'alerting',
-        actions,
+        actions: new Map(actions.map((action) => [action, { gte: 1 }])),
       });
     });
   }