Skip to content

Commit

Permalink
[Workplace Search] Hide Kibana chrome on 3rd party connector redirects (
Browse files Browse the repository at this point in the history
  • Loading branch information
scottybollinger authored Apr 13, 2021
1 parent a66bb53 commit 448562f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import '../../../../__mocks__/shallow_useeffect.mock';

import { setMockActions } from '../../../../__mocks__';
import { setMockActions, setMockValues } from '../../../../__mocks__';

import React from 'react';
import { useLocation } from 'react-router-dom';
Expand All @@ -20,9 +20,11 @@ import { SourceAdded } from './source_added';

describe('SourceAdded', () => {
const saveSourceParams = jest.fn();
const setChromeIsVisible = jest.fn();

beforeEach(() => {
setMockActions({ saveSourceParams });
setMockValues({ setChromeIsVisible });
});

it('renders', () => {
Expand All @@ -32,5 +34,6 @@ describe('SourceAdded', () => {

expect(wrapper.find(Loading)).toHaveLength(1);
expect(saveSourceParams).toHaveBeenCalled();
expect(setChromeIsVisible).toHaveBeenCalled();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ import React, { useEffect } from 'react';
import { useLocation } from 'react-router-dom';

import { Location } from 'history';
import { useActions } from 'kea';
import { useActions, useValues } from 'kea';

import { EuiPage, EuiPageBody } from '@elastic/eui';

import { KibanaLogic } from '../../../../shared/kibana';
import { Loading } from '../../../../shared/loading';

import { AddSourceLogic } from './add_source/add_source_logic';
Expand All @@ -24,8 +25,12 @@ import { AddSourceLogic } from './add_source/add_source_logic';
*/
export const SourceAdded: React.FC = () => {
const { search } = useLocation() as Location;
const { setChromeIsVisible } = useValues(KibanaLogic);
const { saveSourceParams } = useActions(AddSourceLogic);

// We don't want the personal dashboard to flash the Kibana chrome, so we hide it.
setChromeIsVisible(false);

useEffect(() => {
saveSourceParams(search);
}, []);
Expand Down

0 comments on commit 448562f

Please sign in to comment.