fix types

elastic · May 25, 2021 · 42991e8 · 42991e8
1 parent 3c82724
commit 42991e8
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 11 deletions.
diff --git a/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts b/...rvability/public/components/shared/exploratory_view/configurations/constants/constants.ts
@@ -12,6 +12,7 @@ import {
   BROWSER_FAMILY_LABEL,
   BROWSER_VERSION_LABEL,
   CLS_LABEL,
+  CORE_WEB_VITALS_LABEL,
   CPU_USAGE_LABEL,
   DEVICE_LABEL,
   ENVIRONMENT_LABEL,
@@ -92,6 +93,7 @@ export const DataViewLabels: Record<ReportViewTypeId, string> = {
   logs: LOGS_FREQUENCY_LABEL,
   mem: MEMORY_USAGE_LABEL,
   nwk: NETWORK_ACTIVITY_LABEL,
+  cwv: CORE_WEB_VITALS_LABEL,
 };
 
 export const ReportToDataTypeMap: Record<ReportViewTypeId, AppDataType> = {
@@ -105,6 +107,7 @@ export const ReportToDataTypeMap: Record<ReportViewTypeId, AppDataType> = {
   mem: 'infra_metrics',
   logs: 'infra_logs',
   cpu: 'infra_metrics',
+  cwv: 'ux',
 };
 
 export const USE_BREAK_DOWN_COLUMN = 'USE_BREAK_DOWN_COLUMN';

diff --git a/...bservability/public/components/shared/exploratory_view/configurations/constants/labels.ts b/...bservability/public/components/shared/exploratory_view/configurations/constants/labels.ts
@@ -200,6 +200,14 @@ export const NETWORK_ACTIVITY_LABEL = i18n.translate(
     defaultMessage: 'Network activity',
   }
 );
+
+export const CORE_WEB_VITALS_LABEL = i18n.translate(
+  'xpack.observability.expView.fieldLabels.coreWebVitals',
+  {
+    defaultMessage: 'Core web vitals',
+  }
+);
+
 export const MEMORY_USAGE_LABEL = i18n.translate(
   'xpack.observability.expView.fieldLabels.memoryUsage',
   {

diff --git a/...ublic/components/shared/exploratory_view/series_builder/columns/report_definition_col.tsx b/...ublic/components/shared/exploratory_view/series_builder/columns/report_definition_col.tsx
@@ -68,7 +68,7 @@ export function ReportDefinitionCol({
       </EuiFlexItem>
       <EuiHorizontalRule margin="xs" />
       {indexPattern &&
-        reportDefinitions.map(({ field, custom, options, defaultValue }) => (
+        reportDefinitions.map(({ field, custom, options }) => (
           <EuiFlexItem key={field}>
             {!custom ? (
               <ReportDefinitionField
@@ -78,12 +78,7 @@ export function ReportDefinitionCol({
                 onChange={onChange}
               />
             ) : (
-              <CustomReportField
-                field={field}
-                options={options}
-                defaultValue={defaultValue}
-                seriesId={seriesId}
-              />
+              <CustomReportField field={field} options={options} seriesId={seriesId} />
             )}
           </EuiFlexItem>
         ))}

diff --git a/...vability/public/components/shared/exploratory_view/series_builder/custom_report_field.tsx b/...vability/public/components/shared/exploratory_view/series_builder/custom_report_field.tsx
@@ -17,7 +17,7 @@ interface Props {
   options: ReportDefinition['options'];
 }
 
-export function CustomReportField({ field, seriesId, options: opts, defaultValue }: Props) {
+export function CustomReportField({ field, seriesId, options: opts }: Props) {
   const { series, setSeries } = useUrlStorage(seriesId);
 
   const { reportDefinitions: rtd = {} } = series;
@@ -39,7 +39,7 @@ export function CustomReportField({ field, seriesId, options: opts, defaultValue
         value: fd || id,
         inputDisplay: label,
       }))}
-      valueOfSelected={reportDefinitions?.[field]?.[0] || defaultValue || options?.[0].field}
+      valueOfSelected={reportDefinitions?.[field]?.[0] || options?.[0].field}
       onChange={(value) => onChange(value)}
     />
   );

diff --git a/...ervability/public/components/shared/exploratory_view/series_editor/chart_edit_options.tsx b/...ervability/public/components/shared/exploratory_view/series_editor/chart_edit_options.tsx
@@ -20,7 +20,7 @@ export function ChartEditOptions({ series, seriesId, breakdowns }: Props) {
   return (
     <EuiFlexGroup wrap>
       <EuiFlexItem>
-        <Breakdowns seriesId={seriesId} breakdowns={breakdowns} />
+        <Breakdowns seriesId={seriesId} breakdowns={breakdowns} reportViewConfig={series} />
       </EuiFlexItem>
       <EuiFlexItem>
         <ChartOptions series={series} />

diff --git a/...ervability/public/components/shared/exploratory_view/series_editor/columns/breakdowns.tsx b/...ervability/public/components/shared/exploratory_view/series_editor/columns/breakdowns.tsx
@@ -8,7 +8,7 @@
 import React from 'react';
 import { EuiSuperSelect } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { FieldLabels, USE_BREAK_DOWN_COLUMN } from '../../configurations/constants';
+import { USE_BREAK_DOWN_COLUMN } from '../../configurations/constants';
 import { useUrlStorage } from '../../hooks/use_url_storage';
 import { DataSeries } from '../../types';