clean up

elastic · Dec 9, 2024 · 400334b · 400334b
1 parent 1dbfa4e
commit 400334b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 18 deletions.
diff --git a/...components/mappings_editor/components/document_fields/field_parameters/type_parameter.tsx b/...components/mappings_editor/components/document_fields/field_parameters/type_parameter.tsx
@@ -24,7 +24,7 @@ interface Props {
   isMultiField?: boolean | null;
   showDocLink?: boolean;
   isSemanticTextEnabled?: boolean;
-  fieldTypeInputRef: React.MutableRefObject<HTMLInputElement | null>;
+  fieldTypeInputRef?: React.MutableRefObject<HTMLInputElement | null>;
 }
 
 export const TypeParameter = ({

diff --git a/...on/components/mappings_editor/components/document_fields/fields/edit_field/edit_field.tsx b/...on/components/mappings_editor/components/document_fields/fields/edit_field/edit_field.tsx
@@ -59,17 +59,12 @@ const FormWrapper: React.FC<{ children?: React.ReactNode }> = ({ children }) =>
 
 export const EditField = React.memo(
   ({ form, field, allFields, exitEdit, updateField, kibanaVersion }: Props) => {
-    const fieldTypeInputRef = useRef<HTMLInputElement>(null);
-
     const submitForm = async () => {
       const { isValid, data } = await form.submit();
 
       if (isValid) {
         updateField({ ...field, source: data });
       }
-      if (fieldTypeInputRef.current) {
-        fieldTypeInputRef.current.focus();
-      }
     };
 
     const { isMultiField } = field;
@@ -154,7 +149,6 @@ export const EditField = React.memo(
             defaultValue={field.source}
             isRootLevelField={field.parentId === undefined}
             isMultiField={isMultiField}
-            fieldTypeInputRef={fieldTypeInputRef}
           />
 
           <FormDataProvider pathsToWatch={['type', 'subType']}>

diff --git a/...s/mappings_editor/components/document_fields/fields/edit_field/edit_field_header_form.tsx b/...s/mappings_editor/components/document_fields/fields/edit_field/edit_field_header_form.tsx
@@ -19,7 +19,6 @@ interface Props {
   defaultValue: Field;
   isRootLevelField: boolean;
   isMultiField: boolean;
-  fieldTypeInputRef: React.MutableRefObject<HTMLInputElement | null>;
 }
 
 const getTypeDefinition = (type: MainType, subType: SubType): DataTypeDefinition | undefined => {
@@ -42,7 +41,7 @@ const getTypeDefinition = (type: MainType, subType: SubType): DataTypeDefinition
 };
 
 export const EditFieldHeaderForm = React.memo(
-  ({ defaultValue, isRootLevelField, isMultiField, fieldTypeInputRef }: Props) => {
+  ({ defaultValue, isRootLevelField, isMultiField }: Props) => {
     return (
       <>
         <EuiFlexGroup gutterSize="s">
@@ -53,11 +52,7 @@ export const EditFieldHeaderForm = React.memo(
 
           {/* Field type */}
           <EuiFlexItem>
-            <TypeParameter
-              isRootLevelField={isRootLevelField}
-              isMultiField={isMultiField}
-              fieldTypeInputRef={fieldTypeInputRef}
-            />
+            <TypeParameter isRootLevelField={isRootLevelField} isMultiField={isMultiField} />
           </EuiFlexItem>
 
           {/* Field subType (if any) */}

diff --git a/.../application/components/mappings_editor/components/document_fields/fields_tree_editor.tsx b/.../application/components/mappings_editor/components/document_fields/fields_tree_editor.tsx
@@ -36,10 +36,7 @@ export const DocumentFieldsTreeEditor = ({
 
   const addField = useCallback(() => {
     dispatch({ type: 'documentField.createField' });
-    if (createFieldFormRef.current) {
-      createFieldFormRef.current.focus();
-    }
-  }, [dispatch, createFieldFormRef.current]);
+  }, [dispatch]);
 
   const renderCreateField = () => {
     // The "fieldToAddFieldTo" is undefined when adding to the top level "properties" object.