fix jest

elastic · Feb 16, 2021 · 3ecb615 · 3ecb615
1 parent 5ecdcbd
commit 3ecb615
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.test.ts b/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.test.ts
@@ -18,7 +18,7 @@ describe('FieldSuggestions', () => {
 
   beforeEach(() => {
     const uiSettings = { get: (key: string) => shouldSuggestValues } as IUiSettingsClient;
-    http = { fetch: jest.fn() };
+    http = { fetch: jest.fn().mockResolvedValue([]) };
 
     getValueSuggestions = setupValueSuggestionProvider({ http, uiSettings } as CoreSetup, {
       timefilter: ({

diff --git a/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.ts b/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.ts
@@ -48,7 +48,6 @@ export const setupValueSuggestionProvider = (
   }: { timefilter: TimefilterSetup; usageCollector?: AutocompleteUsageCollector }
 ): ValueSuggestionsGetFn => {
   function resolver(title: string, field: IFieldType, query: string, filters: any[]) {
-    usageCollector?.trackCall();
     // Only cache results for a minute
     const ttl = Math.floor(Date.now() / 1000 / 60);
     return [ttl, query, title, field.name, JSON.stringify(filters)].join('|');
@@ -98,6 +97,7 @@ export const setupValueSuggestionProvider = (
     const filterQuery = timeFilter ? buildQueryFromFilters([timeFilter], indexPattern).filter : [];
     const filters = [...(boolFilter ? boolFilter : []), ...filterQuery];
     try {
+      usageCollector?.trackCall();
       return await requestSuggestions(title, field, query, filters, signal);
     } catch (e) {
       if (!signal?.aborted) {

diff --git a/src/plugins/data/public/ui/typeahead/__snapshots__/suggestions_component.test.tsx.snap b/src/plugins/data/public/ui/typeahead/__snapshots__/suggestions_component.test.tsx.snap
diff --git a/src/plugins/data/public/ui/typeahead/suggestions_component.test.tsx b/src/plugins/data/public/ui/typeahead/suggestions_component.test.tsx
@@ -115,7 +115,7 @@ describe('SuggestionsComponent', () => {
 
     component.find(SuggestionComponent).at(1).simulate('click');
     expect(mockCallback).toHaveBeenCalledTimes(1);
-    expect(mockCallback).toHaveBeenCalledWith(mockSuggestions[1]);
+    expect(mockCallback).toHaveBeenCalledWith(mockSuggestions[1], 1);
   });
 
   it('Should call onMouseEnter with the index of the suggestion that was entered', () => {