Skip to content

Commit

Permalink
self review
Browse files Browse the repository at this point in the history
  • Loading branch information
pgayvallet committed Dec 3, 2020
1 parent a9e21d5 commit 3e740c6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export class RollingFileAppender implements DisposableAppender {
}

/**
* Checks if the current even should trigger a rollout
* Checks if the current event should trigger a rollout
*/
private needRollout(record: LogRecord) {
return this.policy.isTriggeringEvent(record);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const createNumericMatcher = (fileBaseName: string, pattern: string): RegExp =>
* matcher('kibana-1.log') // `1`
* matcher('kibana-5.log') // `5`
* matcher('kibana-A.log') // undefined
* matcher('kibana.log') // `undefined
* matcher('kibana.log') // undefined
* ```
*/
export const getFileNameMatcher = (logFileName: string, pattern: string) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ export const shouldSkipRollout = async ({ logFilePath }: { logFilePath: string }
return !(await exists(logFilePath));
};

/**
* Returns the rolled file basenames, from the most recent to the oldest.
*/
export const getOrderedRolledFiles = async ({
logFileBaseName,
logFileFolder,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

/**
* A strategy to perform the log file rollout.
* A strategy to perform the log file rollover.
*/
export interface RollingStrategy {
/**
Expand Down

0 comments on commit 3e740c6

Please sign in to comment.