Require script when first adding a field. Shorten painless script edi…

…tor. Remove error callout.
elastic · Sep 22, 2020 · 3ac63a6 · 3ac63a6
1 parent 8a53f68
commit 3ac63a6
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 32 deletions.
diff --git a/...mappings_editor/components/document_fields/field_parameters/painless_script_parameter.tsx b/...mappings_editor/components/document_fields/field_parameters/painless_script_parameter.tsx
@@ -5,7 +5,7 @@
  */
 
 import React from 'react';
-import { EuiFormRow, EuiCallOut, EuiSpacer } from '@elastic/eui';
+import { EuiFormRow } from '@elastic/eui';
 
 import { CodeEditor, UseField } from '../../../shared_imports';
 import { getFieldConfig } from '../../../lib';
@@ -18,35 +18,26 @@ export const PainlessScriptParameter = () => {
         const isInvalid = error ? Boolean(error.length) : false;
 
         return (
-          <>
-            {isInvalid && (
-              <>
-                <EuiCallOut size="s" color="danger" title={error} />
-                <EuiSpacer />
-              </>
-            )}
-
-            <EuiFormRow label={scriptField.label} error={error} isInvalid={isInvalid} fullWidth>
-              <CodeEditor
-                languageId="painless"
-                // 99% width allows the editor to resize horizontally. 100% prevents it from resizing.
-                width="99%"
-                height="800px"
-                value={scriptField.value as string}
-                onChange={scriptField.setValue}
-                options={{
-                  fontSize: 12,
-                  minimap: {
-                    enabled: false,
-                  },
-                  scrollBeyondLastLine: false,
-                  wordWrap: 'on',
-                  wrappingIndent: 'indent',
-                  automaticLayout: true,
-                }}
-              />
-            </EuiFormRow>
-          </>
+          <EuiFormRow label={scriptField.label} error={error} isInvalid={isInvalid} fullWidth>
+            <CodeEditor
+              languageId="painless"
+              // 99% width allows the editor to resize horizontally. 100% prevents it from resizing.
+              width="99%"
+              height="400px"
+              value={scriptField.value as string}
+              onChange={scriptField.setValue}
+              options={{
+                fontSize: 12,
+                minimap: {
+                  enabled: false,
+                },
+                scrollBeyondLastLine: false,
+                wordWrap: 'on',
+                wrappingIndent: 'indent',
+                automaticLayout: true,
+              }}
+            />
+          </EuiFormRow>
         );
       }}
     </UseField>

diff --git a/...components/document_fields/fields/create_field/required_parameters_forms/runtime_type.tsx b/...components/document_fields/fields/create_field/required_parameters_forms/runtime_type.tsx
@@ -6,8 +6,13 @@
 
 import React from 'react';
 
-import { RuntimeTypeParameter } from '../../../field_parameters';
+import { RuntimeTypeParameter, PainlessScriptParameter } from '../../../field_parameters';
 
 export const RuntimeTypeRequiredParameters = () => {
-  return <RuntimeTypeParameter />;
+  return (
+    <>
+      <RuntimeTypeParameter />
+      <PainlessScriptParameter />
+    </>
+  );
 };