Handle api errors on event filters and trusted apps summary api calls

elastic · May 27, 2021 · 39c8133 · 39c8133
1 parent 5b17fd5
commit 39c8133
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 9 deletions.
diff --git a/...ger_integration/endpoint_package_custom_extension/components/fleet_event_filters_card.tsx b/...ger_integration/endpoint_package_custom_extension/components/fleet_event_filters_card.tsx
@@ -19,6 +19,7 @@ import { getEventFiltersListPath } from '../../../../../../common/routing';
 import { GetExceptionSummaryResponse } from '../../../../../../../../common/endpoint/types';
 import { PLUGIN_ID as FLEET_PLUGIN_ID } from '../../../../../../../../../fleet/common';
 import { MANAGEMENT_APP_ID } from '../../../../../../common/constants';
+import { useToasts } from '../../../../../../../common/lib/kibana';
 import { LinkWithIcon } from './link_with_icon';
 import { ExceptionItemsSummary } from './exception_items_summary';
 import { EventFiltersHttpService } from '../../../../../event_filters/service';
@@ -30,18 +31,29 @@ export const FleetEventFiltersCard = memo<PackageCustomExtensionComponentProps>(
       http,
     },
   } = useKibana<CoreStart & { application: ApplicationStart }>();
-
+  const toasts = useToasts();
   const [stats, setStats] = useState<GetExceptionSummaryResponse | undefined>();
   const eventFiltersListUrlPath = getEventFiltersListPath();
   const eventFiltersApi = useMemo(() => new EventFiltersHttpService(http), [http]);
 
   useEffect(() => {
     const fetchStats = async () => {
-      const summary = await eventFiltersApi.getSummary();
-      setStats(summary);
+      try {
+        const summary = await eventFiltersApi.getSummary();
+        setStats(summary);
+      } catch (err) {
+        toasts.addDanger(
+          i18n.translate(
+            'xpack.securitySolution.endpoint.fleetCustomExtension.eventFiltersSummaryError',
+            {
+              defaultMessage: 'There was an error trying to fetch event filters stats',
+            }
+          )
+        );
+      }
     };
     fetchStats();
-  }, [eventFiltersApi]);
+  }, [eventFiltersApi, toasts]);
 
   const eventFiltersRouteState = useMemo(() => {
     const fleetPackageCustomUrlPath = `#${pagePathGetters.integration_details_custom({ pkgkey })}`;

diff --git a/...ager_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.tsx b/...ager_integration/endpoint_package_custom_extension/components/fleet_trusted_apps_card.tsx
@@ -22,6 +22,7 @@ import {
 } from '../../../../../../../../common/endpoint/types';
 import { PLUGIN_ID as FLEET_PLUGIN_ID } from '../../../../../../../../../fleet/common';
 import { MANAGEMENT_APP_ID } from '../../../../../../common/constants';
+import { useToasts } from '../../../../../../../common/lib/kibana';
 import { LinkWithIcon } from './link_with_icon';
 import { ExceptionItemsSummary } from './exception_items_summary';
 import { TrustedAppsHttpService } from '../../../../../trusted_apps/service';
@@ -33,15 +34,28 @@ export const FleetTrustedAppsCard = memo<PackageCustomExtensionComponentProps>((
       http,
     },
   } = useKibana<CoreStart & { application: ApplicationStart }>();
-
+  const toasts = useToasts();
   const [stats, setStats] = useState<GetExceptionSummaryResponse | undefined>();
   const trustedAppsApi = useMemo(() => new TrustedAppsHttpService(http), [http]);
 
   useEffect(() => {
-    trustedAppsApi.getTrustedAppsSummary().then((response) => {
-      setStats(response);
-    });
-  }, [trustedAppsApi]);
+    const fetchStats = async () => {
+      try {
+        const response = await trustedAppsApi.getTrustedAppsSummary();
+        setStats(response);
+      } catch (err) {
+        toasts.addDanger(
+          i18n.translate(
+            'xpack.securitySolution.endpoint.fleetCustomExtension.eventFiltersSummaryError',
+            {
+              defaultMessage: 'There was an error trying to fetch trusted apps stats',
+            }
+          )
+        );
+      }
+    };
+    fetchStats();
+  }, [toasts, trustedAppsApi]);
   const trustedAppsListUrlPath = getTrustedAppsListPath();
 
   const trustedAppRouteState = useMemo<TrustedAppsListPageRouteState>(() => {