Skip to content

Commit

Permalink
[plugins] change plugin ids to be snakecase
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed Feb 26, 2016
1 parent 3e75120 commit 36cdae8
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/plugins/dev_mode/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "devMode",
"name": "dev_mode",
"version": "1.0.0"
}
2 changes: 1 addition & 1 deletion src/plugins/spy_modes/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "spyModes",
"name": "spy_modes",
"version": "1.0.0"
}
2 changes: 1 addition & 1 deletion src/plugins/status_page/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "statusPage",
"name": "status_page",
"version": "1.0.0"
}
4 changes: 2 additions & 2 deletions src/plugins/tests_bundle/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default (kibana) => {
let config = kibana.config;

const testGlobs = ['src/ui/public/**/*.js'];
const testingPluginId = config.get('testsBundle.pluginId');
const testingPluginId = config.get('tests_bundle.pluginId');

if (testingPluginId) {
const plugin = plugins.byId[testingPluginId];
Expand Down Expand Up @@ -49,7 +49,7 @@ export default (kibana) => {
const testFiles = await findSourceFiles(testGlobs);
for (let f of testFiles) modules.push(f);

if (config.get('testsBundle.instrument')) {
if (config.get('tests_bundle.instrument')) {
env.addPostLoader({
test: /\.jsx?$/,
exclude: /[\/\\](__tests__|node_modules|bower_components|webpackShims)[\/\\]/,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/tests_bundle/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "testsBundle",
"name": "tests_bundle",
"version": "0.0.0"
}
2 changes: 1 addition & 1 deletion src/server/status/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = function (kbnServer, server, config) {
});

server.decorate('reply', 'renderStatusPage', function () {
var app = kbnServer.uiExports.getHiddenApp('statusPage');
var app = kbnServer.uiExports.getHiddenApp('status_page');
var resp = app ? this.renderApp(app) : this(kbnServer.status.toString());
resp.code(kbnServer.status.isGreen() ? 200 : 503);
return resp;
Expand Down
2 changes: 1 addition & 1 deletion tasks/config/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ module.exports = function (grunt) {
args: [
...buildTestsArgs,
'--server.port=5610',
'--testsBundle.instrument=true',
'--tests_bundle.instrument=true',
...kbnServerFlags,
]
},
Expand Down
4 changes: 2 additions & 2 deletions test/functional/status_page/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ define(function (require) {
bdd.before(function () {
common = new Common(this.remote);
// load the status page
return common.navigateToApp('statusPage', false);
return common.navigateToApp('status_page', false);
});

bdd.it('should show the kibana plugin as ready', function () {
Expand All @@ -27,4 +27,4 @@ define(function (require) {
.catch(common.handleError(self));
});
});
});
});

0 comments on commit 36cdae8

Please sign in to comment.