Skip to content

Commit

Permalink
[Security Solution, Cases] Adds Explicit deprecation levels (#118268) (
Browse files Browse the repository at this point in the history
…#118415)

* Add level for security solution deprecations

These are all marked as critical, since behavior will be degraded if
users have these old keys (i.e. those settings will be ignored).

* Add critical level to cases config deprecation

Use of the old config name will be ignored and thus change behavior.

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/cases/server/index.ts
#	x-pack/plugins/security_solution/server/index.ts

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
rylnd and kibanamachine authored Nov 12, 2021
1 parent 0187c77 commit 35eb5ba
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const config: PluginConfigDescriptor<ConfigType> = {
},
deprecations: ({ deprecate, renameFromRoot }) => [
deprecate('enabled', '8.0.0'),
renameFromRoot('xpack.case.enabled', 'xpack.cases.enabled'),
renameFromRoot('xpack.case.enabled', 'xpack.cases.enabled', { level: 'critical' }),
],
};
export const plugin = (initializerContext: PluginInitializerContext) =>
Expand Down
17 changes: 11 additions & 6 deletions x-pack/plugins/security_solution/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,31 @@ export const config: PluginConfigDescriptor<ConfigSchema> = {
schema: configSchema,
deprecations: ({ deprecate, renameFromRoot }) => [
deprecate('enabled', '8.0.0'),
renameFromRoot('xpack.siem.enabled', 'xpack.securitySolution.enabled'),
renameFromRoot('xpack.siem.enabled', 'xpack.securitySolution.enabled', { level: 'critical' }),
renameFromRoot(
'xpack.siem.maxRuleImportExportSize',
'xpack.securitySolution.maxRuleImportExportSize'
'xpack.securitySolution.maxRuleImportExportSize',
{ level: 'critical' }
),
renameFromRoot(
'xpack.siem.maxRuleImportPayloadBytes',
'xpack.securitySolution.maxRuleImportPayloadBytes'
'xpack.securitySolution.maxRuleImportPayloadBytes',
{ level: 'critical' }
),
renameFromRoot(
'xpack.siem.maxTimelineImportExportSize',
'xpack.securitySolution.maxTimelineImportExportSize'
'xpack.securitySolution.maxTimelineImportExportSize',
{ level: 'critical' }
),
renameFromRoot(
'xpack.siem.maxTimelineImportPayloadBytes',
'xpack.securitySolution.maxTimelineImportPayloadBytes'
'xpack.securitySolution.maxTimelineImportPayloadBytes',
{ level: 'critical' }
),
renameFromRoot(
`xpack.siem.${SIGNALS_INDEX_KEY}`,
`xpack.securitySolution.${SIGNALS_INDEX_KEY}`
`xpack.securitySolution.${SIGNALS_INDEX_KEY}`,
{ level: 'critical' }
),
],
};
Expand Down

0 comments on commit 35eb5ba

Please sign in to comment.