Apply suggestions from code review

Co-Authored-By: Aleh Zasypkin <[email protected]>
elastic · Feb 5, 2020 · 35b81ea · 35b81ea
1 parent 73cc266
commit 35b81ea
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...ins/spaces/public/copy_saved_objects_to_space/copy_saved_objects_to_space_service.test.ts b/...ins/spaces/public/copy_saved_objects_to_space/copy_saved_objects_to_space_service.test.ts
@@ -16,7 +16,7 @@ describe('CopySavedObjectsToSpaceService', () => {
     it('registers the CopyToSpaceSavedObjectsManagementAction', () => {
       const deps = {
         spacesManager: spacesManagerMock.create(),
-        notificationsSetup: (notificationServiceMock.create()
+        notificationsSetup: notificationServiceMock.createSetupContract()
           .setup as unknown) as NotificationsSetup,
         // we don't have a proper NP mock for this yet
         managementSetup: ({

diff --git a/x-pack/plugins/spaces/public/management/edit_space/delete_spaces_button.test.tsx b/x-pack/plugins/spaces/public/management/edit_space/delete_spaces_button.test.tsx
@@ -22,7 +22,7 @@ describe('DeleteSpacesButton', () => {
   it('renders as expected', () => {
     const spacesManager = spacesManagerMock.create();
 
-    const notificatons = (notificationServiceMock.create().start as unknown) as NotificationsStart;
+    const notifications = notificationServiceMock.createStartContract();
 
     const wrapper = shallowWithIntl(
       <DeleteSpacesButton.WrappedComponent

diff --git a/x-pack/plugins/spaces/public/management/spaces_management_app.tsx b/x-pack/plugins/spaces/public/management/spaces_management_app.tsx
@@ -51,7 +51,7 @@ export const spacesManagementApp = Object.freeze({
               http={http}
               notifications={notifications}
               spacesManager={spacesManager}
-              securityEnabled={Boolean(securityLicense && securityLicense.getFeatures().showLinks)}
+              securityEnabled={securityLicense?.getFeatures().showLinks ?? false}
             />
           );
         };

diff --git a/x-pack/plugins/spaces/public/plugin.tsx b/x-pack/plugins/spaces/public/plugin.tsx
@@ -60,7 +60,7 @@ export class SpacesPlugin implements Plugin<SpacesPluginSetup, SpacesPluginStart
         management: plugins.management,
         getStartServices: core.getStartServices,
         spacesManager: this.spacesManager,
-        securityLicense: plugins.security && plugins.security.license,
+        securityLicense: plugins.security?.license,
       });
     }