[ML] Client side cut over (#60100)

* [ML] Client side cut over

* updating paths and commented code

* changes based on review

* disabling telemetry tests

* fixing start job stylesheets

* fixing everything that is broken

* fixing types and ml icon order

* using icon constant

.eslintrc.js

@@ -142,7 +142,7 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/legacy/plugins/ml/**/*.{js,ts,tsx}'],
+      files: ['x-pack/plugins/ml/**/*.{js,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
       },

x-pack/index.js

@@ -9,7 +9,6 @@ import { graph } from './legacy/plugins/graph';
 import { monitoring } from './legacy/plugins/monitoring';
 import { reporting } from './legacy/plugins/reporting';
 import { security } from './legacy/plugins/security';
-import { ml } from './legacy/plugins/ml';
 import { tilemap } from './legacy/plugins/tilemap';
 import { grokdebugger } from './legacy/plugins/grokdebugger';
 import { dashboardMode } from './legacy/plugins/dashboard_mode';
@@ -45,7 +44,6 @@ module.exports = function(kibana) {
     reporting(kibana),
     spaces(kibana),
     security(kibana),
-    ml(kibana),
     tilemap(kibana),
     grokdebugger(kibana),
     dashboardMode(kibana),

x-pack/legacy/plugins/ml/common/constants/app.ts → x-pack/plugins/ml/common/constants/app.ts

@@ -5,3 +5,4 @@
  */
 
 export const PLUGIN_ID = 'ml';
+export const PLUGIN_ICON = 'machineLearningApp';

x-pack/legacy/plugins/ml/common/license/ml_license.ts → x-pack/plugins/ml/common/license/ml_license.ts

@@ -5,7 +5,7 @@
  */
 
 import { Observable, Subscription } from 'rxjs';
-import { ILicense, LICENSE_CHECK_STATE } from '../../../../../plugins/licensing/common/types';
+import { ILicense, LICENSE_CHECK_STATE } from '../../../licensing/common/types';
 import { PLUGIN_ID } from '../constants/app';
 
 export const MINIMUM_LICENSE = 'basic';

x-pack/legacy/plugins/ml/common/types/fields.ts → x-pack/plugins/ml/common/types/fields.ts

@@ -4,13 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { ES_FIELD_TYPES } from '../../../../../../src/plugins/data/common';
+import { ES_FIELD_TYPES } from '../../../../../src/plugins/data/common';
 import {
   ML_JOB_AGGREGATION,
   KIBANA_AGGREGATION,
   ES_AGGREGATION,
-} from '../../common/constants/aggregation_types';
-import { MLCATEGORY } from '../../common/constants/field_types';
+} from '../constants/aggregation_types';
+import { MLCATEGORY } from '../constants/field_types';
 
 export const EVENT_RATE_FIELD_ID = '__ml_event_rate_count__';
 export const METRIC_AGG_TYPE = 'metrics';

x-pack/legacy/plugins/ml/common/types/modules.ts → x-pack/plugins/ml/common/types/modules.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { SavedObjectAttributes } from 'kibana/public';
-import { Datafeed, Job } from '../types/anomaly_detection_jobs';
+import { Datafeed, Job } from './anomaly_detection_jobs';
 
 export interface ModuleJob {
   id: string;

x-pack/legacy/plugins/ml/common/util/job_utils.js → x-pack/plugins/ml/common/util/job_utils.js

@@ -11,7 +11,7 @@ import numeral from '@elastic/numeral';
 import { ALLOWED_DATA_UNITS, JOB_ID_MAX_LENGTH } from '../constants/validation';
 import { parseInterval } from './parse_interval';
 import { maxLengthValidator } from './validators';
-import { CREATED_BY_LABEL } from '../../common/constants/new_job';
+import { CREATED_BY_LABEL } from '../constants/new_job';
 
 // work out the default frequency based on the bucket_span in seconds
 export function calculateDatafeedFrequencyDefaultSeconds(bucketSpanSeconds) {

x-pack/plugins/ml/jsconfig.json

@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "target": "es6",
+    "module": "commonjs",
+    "baseUrl": "../../../.",
+    "paths": {
+      "ui/*": ["src/legacy/ui/public/*"],
+      "plugins/ml/*": ["x-pack/plugins/ml/public/*"]
+    }
+  },
+  "exclude": ["node_modules", "build"]
+}

x-pack/plugins/ml/kibana.json

@@ -1,10 +1,24 @@
 {
   "id": "ml",
-  "version": "0.0.1",
+  "version": "8.0.0",
   "kibanaVersion": "kibana",
-  "configPath": ["ml"],
-  "requiredPlugins": ["cloud", "features", "home", "licensing", "usageCollection"],
-  "optionalPlugins": ["security", "spaces"],
+  "configPath": [
+    "xpack",
+    "ml"
+  ],
+  "requiredPlugins": [
+    "data",
+    "cloud",
+    "features",
+    "home",
+    "licensing",
+    "usageCollection"
+  ],
+  "optionalPlugins": [
+    "security",
+    "spaces",
+    "management"
+  ],
   "server": true,
-  "ui": false
+  "ui": true
 }

x-pack/legacy/plugins/ml/public/application/index.scss → x-pack/plugins/ml/public/application/_index.scss

@@ -11,7 +11,7 @@
 
 // Protect the rest of Kibana from ML generic namespacing
 // SASSTODO: Prefix ml selectors instead
-#ml-app {
+.ml-app {
   // App level
   @import 'app';