Skip to content

Commit

Permalink
[ML] Unskip a11y tests and fix datavisualizer test (#179833)
Browse files Browse the repository at this point in the history
## Summary

Unskips the ML accessibility tests skipped in
#17259 following the change made
to `EuiIcon` in elastic/eui#7606 in EUI v93.5.1.

Also fixes a missing aria-label on the tech preview badge on the data
visualizer selector page which would otherwise cause an accessibility
test failure.

🟢 50x flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5600


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
  • Loading branch information
peteharverson authored Apr 2, 2024
1 parent 8b95195 commit 34d416f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
EuiTextAlign,
} from '@elastic/eui';

import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { useTimefilter } from '@kbn/ml-date-picker';
import { isFullLicense } from '../license';
Expand Down Expand Up @@ -182,6 +183,12 @@ export const DatavisualizerSelector: FC = () => {
/>
}
tooltipPosition={'right'}
aria-label={i18n.translate(
'xpack.ml.datavisualizer.selector.technicalPreviewBadge.ariaLabel',
{
defaultMessage: 'ES|QL is in technical preview.',
}
)}
/>
</>
</EuiTextAlign>
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/accessibility/apps/group2/ml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export default function ({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/172598
describe.skip('with data loaded', function () {
describe('with data loaded', function () {
const dfaOutlierResultsJobId = 'iph_outlier_a11y';
const ecIndexName = 'ft_module_sample_ecommerce';
const ihpIndexName = 'ft_ihp_outlier';
Expand Down

0 comments on commit 34d416f

Please sign in to comment.