Skip to content

Commit

Permalink
[Fleet] Fix displaying agent status bar with no agents
Browse files Browse the repository at this point in the history
  • Loading branch information
nchaulet committed May 3, 2023
1 parent f1360f2 commit 31f754c
Show file tree
Hide file tree
Showing 2 changed files with 71 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import React from 'react';

import { createFleetTestRendererMock } from '../../../../../../mock';

import { AgentStatusBar } from './status_bar';

describe('AgentStatusBar', () => {
it('should render the status bar if there is some agent displayed', () => {
const renderer = createFleetTestRendererMock();
const res = renderer.render(
<AgentStatusBar
agentStatus={
{
healthy: 10,
inactive: 0,
offline: 0,
} as any
}
/>
);
expect(res.queryByTestId('agentStatusBar')).not.toBeNull();
});

it('should not render the status bar if there is no agent displayed', () => {
const renderer = createFleetTestRendererMock();
const res = renderer.render(
<AgentStatusBar
agentStatus={
{
healthy: 0,
inactive: 0,
offline: 0,
} as any
}
/>
);
expect(res.queryByTestId('agentStatusBar')).toBeNull();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import styled from 'styled-components';
import { EuiColorPaletteDisplay } from '@elastic/eui';
import { EuiColorPaletteDisplay, EuiSpacer } from '@elastic/eui';
import React, { useMemo } from 'react';

import { AGENT_STATUSES, getColorForAgentStatus } from '../../services/agent_status';
Expand Down Expand Up @@ -35,13 +35,30 @@ export const AgentStatusBar: React.FC<{
return acc;
}, [] as Array<{ stop: number; color: string }>);
}, [agentStatus]);

// const totalAgents = useMemo(() => {
// return AGENT_STATUSES.reduce((acc, status) => {
// const previousStop = acc.length > 0 ? acc[acc.length - 1].stop : 0;
// acc.push({
// stop: previousStop + (agentStatus[status] || 0),
// color: getColorForAgentStatus(status),
// });
// return acc;
// }, 0);
// }, [agentStatus]);

const hasNoAgent = palette[palette.length - 1].stop === 0;

if (hasNoAgent) {
return <EuiSpacer size="s" />;
}

return (
<>
<StyledEuiColorPaletteDisplay
className="ingest-agent-status-bar"
size="s"
palette={palette}
/>
</>
<StyledEuiColorPaletteDisplay
data-test-subj="agentStatusBar"
className="ingest-agent-status-bar"
size="s"
palette={palette}
/>
);
};

0 comments on commit 31f754c

Please sign in to comment.