code review comments (ash)

elastic · Jul 12, 2023 · 312ebc2 · 312ebc2
1 parent 9b1e5a9
commit 312ebc2
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 9 deletions.
diff --git a/...ent/pages/policy/view/policy_settings_form/components/cards/behaviour_protection_card.tsx b/...ent/pages/policy/view/policy_settings_form/components/cards/behaviour_protection_card.tsx
@@ -13,7 +13,7 @@ import { FormattedMessage } from '@kbn/i18n-react';
 import { useTestIdGenerator } from '../../../../../../hooks/use_test_id_generator';
 import { SettingCard } from '../setting_card';
 import { NotifyUserOption } from '../notify_user_option';
-import { DetectPreventProtectionLevel } from '../detect_prevent_protection_lavel';
+import { DetectPreventProtectionLevel } from '../detect_prevent_protection_level';
 import { ProtectionSettingCardSwitch } from '../protection_setting_card_switch';
 import type { Immutable } from '../../../../../../../../common/endpoint/types';
 import { PolicyOperatingSystem } from '../../../../../../../../common/endpoint/types';

diff --git a/...ment/pages/policy/view/policy_settings_form/components/cards/malware_protections_card.tsx b/...ment/pages/policy/view/policy_settings_form/components/cards/malware_protections_card.tsx
@@ -29,7 +29,7 @@ import type { MalwareProtectionOSes } from '../../../../types';
 import { LinkToApp } from '../../../../../../../common/components/endpoint/link_to_app';
 import type { ProtectionSettingCardSwitchProps } from '../protection_setting_card_switch';
 import { ProtectionSettingCardSwitch } from '../protection_setting_card_switch';
-import { DetectPreventProtectionLevel } from '../detect_prevent_protection_lavel';
+import { DetectPreventProtectionLevel } from '../detect_prevent_protection_level';
 import { useTestIdGenerator } from '../../../../../../hooks/use_test_id_generator';
 
 const BLOCKLIST_ENABLED_LABEL = i18n.translate(

diff --git a/...gement/pages/policy/view/policy_settings_form/components/cards/memory_protection_card.tsx b/...gement/pages/policy/view/policy_settings_form/components/cards/memory_protection_card.tsx
@@ -12,7 +12,7 @@ import { EuiCallOut, EuiSpacer } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { useTestIdGenerator } from '../../../../../../hooks/use_test_id_generator';
 import { NotifyUserOption } from '../notify_user_option';
-import { DetectPreventProtectionLevel } from '../detect_prevent_protection_lavel';
+import { DetectPreventProtectionLevel } from '../detect_prevent_protection_level';
 import { ProtectionSettingCardSwitch } from '../protection_setting_card_switch';
 import { SettingLockedCard } from '../setting_locked_card';
 import type { Immutable } from '../../../../../../../../common/endpoint/types';

diff --git a/...nt/pages/policy/view/policy_settings_form/components/cards/ransomware_protection_card.tsx b/...nt/pages/policy/view/policy_settings_form/components/cards/ransomware_protection_card.tsx
@@ -13,7 +13,7 @@ import { FormattedMessage } from '@kbn/i18n-react';
 import { useTestIdGenerator } from '../../../../../../hooks/use_test_id_generator';
 import { ProtectionSettingCardSwitch } from '../protection_setting_card_switch';
 import { NotifyUserOption } from '../notify_user_option';
-import { DetectPreventProtectionLevel } from '../detect_prevent_protection_lavel';
+import { DetectPreventProtectionLevel } from '../detect_prevent_protection_level';
 import { SettingCard } from '../setting_card';
 import type { PolicyFormComponentCommonProps } from '../../types';
 import type { Immutable } from '../../../../../../../../common/endpoint/types';

diff --git a/...nents/detect_prevent_protection_lavel.tsx → ...nents/detect_prevent_protection_level.tsx b/...nents/detect_prevent_protection_lavel.tsx → ...nents/detect_prevent_protection_level.tsx
@@ -41,7 +41,6 @@ export const DetectPreventProtectionLevel = memo<DetectPreventProtectionLavelPro
     const isEditMode = mode === 'edit';
     const getTestId = useTestIdGenerator(dataTestSubj);
 
-    // FIXME:PT remove this. Make it module global const
     const radios: Immutable<
       Array<{
         id: ProtectionModes;
@@ -170,10 +169,8 @@ const ProtectionRadio = React.memo(
       onChange({ isValid: true, updatedPolicy: newPayload });
     }, [isPlatinumPlus, onChange, osList, policy, protection, protectionMode]);
 
-    // FIXME:PT Why is this className being used below? can it be removed?
     return (
       <EuiRadio
-        className="policyDetailsProtectionRadio"
         label={label}
         id={radioButtonId}
         checked={selected === protectionMode}

diff --git a/...olution/public/management/pages/policy/view/policy_settings_form/policy_settings_form.tsx b/...olution/public/management/pages/policy/view/policy_settings_form/policy_settings_form.tsx
@@ -77,7 +77,7 @@ export const PolicySettingsForm = memo<PolicySettingsFormProps>((props) => {
 });
 PolicySettingsForm.displayName = 'PolicySettingsForm';
 
-export const FormSectionTitle = memo(({ children }) => {
+const FormSectionTitle = memo(({ children }) => {
   return (
     <EuiText size="xs" color="subdued">
       <h4>{children}</h4>

diff --git a/...ugins/security_solution/public/management/pages/policy/view/policy_settings_form/types.ts b/...ugins/security_solution/public/management/pages/policy/view/policy_settings_form/types.ts
@@ -10,6 +10,6 @@ import type { PolicyConfig } from '../../../../../../common/endpoint/types';
 export interface PolicyFormComponentCommonProps {
   policy: PolicyConfig;
   onChange: (options: { isValid: boolean; updatedPolicy: PolicyConfig }) => void;
-  mode?: 'edit' | 'view';
+  mode: 'edit' | 'view';
   'data-test-subj'?: string;
 }