CR feedback

elastic · Apr 8, 2024 · 2f65849 · 2f65849
1 parent ff8a41f
commit 2f65849
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...rver/lib/detection_engine/rule_types/new_terms/bulk_create_suppressed_alerts_in_memory.ts b/...rver/lib/detection_engine/rule_types/new_terms/bulk_create_suppressed_alerts_in_memory.ts
@@ -57,9 +57,10 @@ export interface BulkCreateSuppressedAlertsParams
   experimentalFeatures: ExperimentalFeatures | undefined;
 }
 /**
- * bulk create and suppress alerts in memory,
- * takes care of missing fields logic, i.e. if missing fields configured not to be suppressed,
- * they will be created as regular alerts
+ * wraps, bulk create and suppress alerts in memory, also takes care of missing fields logic.
+ * If parameter alertSuppression.missingFieldsStrategy configured not to be suppressed, regular alerts will be created for such events without suppression
+ * This function is similar to x-pack/plugins/security_solution/server/lib/detection_engine/rule_types/utils/bulk_create_suppressed_alerts_in_memory.ts, but
+ * it operates with new terms specific eventsAndTerms{@link EventsAndTerms} parameter property, instead of regular events as common utility
  */
 export const bulkCreateSuppressedNewTermsAlertsInMemory = async ({
   eventsAndTerms,

diff --git a/...n/server/lib/detection_engine/rule_types/utils/bulk_create_suppressed_alerts_in_memory.ts b/...n/server/lib/detection_engine/rule_types/utils/bulk_create_suppressed_alerts_in_memory.ts
@@ -53,9 +53,8 @@ export interface BulkCreateSuppressedAlertsParams
   experimentalFeatures?: ExperimentalFeatures;
 }
 /**
- * bulk create and suppress alerts in memory,
- * takes care of missing fields logic, i.e. if missing fields configured not to be suppressed,
- * they will be created as regular alerts
+ * wraps, bulk create and suppress alerts in memory, also takes care of missing fields logic.
+ * If parameter alertSuppression.missingFieldsStrategy configured not to be suppressed, regular alerts will be created for such events without suppression
  */
 export const bulkCreateSuppressedAlertsInMemory = async ({
   enrichedEvents,