💄 Distinct icons for XY and pie chart value labels toolbar

elastic · Nov 9, 2020 · 2d8c7b4 · 2d8c7b4
1 parent 8560b2d
commit 2d8c7b4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx b/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx
@@ -11,7 +11,8 @@ import { EuiIconLegend } from '../assets/legend';
 
 const typeToIconMap: { [type: string]: string | IconType } = {
   legend: EuiIconLegend as IconType,
-  values: 'number',
+  values: 'visText',
+  numeric: 'number',
 };
 
 export interface ToolbarPopoverProps {

diff --git a/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx b/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx
@@ -262,7 +262,7 @@ export function XyToolbar(props: VisualizationToolbarProps<State>) {
               title={i18n.translate('xpack.lens.xyChart.valuesLabel', {
                 defaultMessage: 'Values',
               })}
-              type="values"
+              type="numeric"
               groupPosition="left"
               buttonDataTestSubj="lnsValuesButton"
               isDisabled={!isValueLabelsEnabled && !isFittingEnabled}