Skip to content

Commit

Permalink
Remove duplicate service
Browse files Browse the repository at this point in the history
  • Loading branch information
cqliu1 committed Sep 9, 2024
1 parent 8094cf7 commit 2d78569
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
]);
const dashboardCustomizePanel = getService('dashboardCustomizePanel');
const dashboardBadgeActions = getService('dashboardBadgeActions');
const dashboardPanelActions = getService('dashboardPanelActions');
const testSubjects = getService('testSubjects');
const retry = getService('retry');
const panelActions = getService('dashboardPanelActions');
Expand All @@ -47,7 +46,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

await dashboard.waitForRenderComplete();
const originalEmbeddableCount = await canvas.getEmbeddableCount();
await dashboardPanelActions.customizePanel();
await panelActions.customizePanel();
await dashboardCustomizePanel.enableCustomTimeRange();
await dashboardCustomizePanel.openDatePickerQuickMenu();
await dashboardCustomizePanel.clickCommonlyUsedTimeRange('Last_30 days');
Expand Down Expand Up @@ -125,7 +124,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const titles = await dashboard.getPanelTitles();
expect(titles[0]).to.be(`${visTitle} (converted)`);

await dashboardPanelActions.expectNotLinkedToLibrary(titles[0], true);
await panelActions.expectNotLinkedToLibrary(titles[0], true);
await dashboardBadgeActions.expectExistsTimeRangeBadgeAction();
await panelActions.removePanel();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
]);
const dashboardCustomizePanel = getService('dashboardCustomizePanel');
const dashboardBadgeActions = getService('dashboardBadgeActions');
const dashboardPanelActions = getService('dashboardPanelActions');
const testSubjects = getService('testSubjects');
const retry = getService('retry');
const panelActions = getService('dashboardPanelActions');
Expand Down Expand Up @@ -47,7 +46,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

await dashboard.waitForRenderComplete();
const originalEmbeddableCount = await canvas.getEmbeddableCount();
await dashboardPanelActions.customizePanel();
await panelActions.customizePanel();
await dashboardCustomizePanel.enableCustomTimeRange();
await dashboardCustomizePanel.openDatePickerQuickMenu();
await dashboardCustomizePanel.clickCommonlyUsedTimeRange('Last_30 days');
Expand Down Expand Up @@ -84,7 +83,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await dashboard.waitForRenderComplete();
const originalEmbeddableCount = await canvas.getEmbeddableCount();

await dashboardPanelActions.customizePanel();
await panelActions.customizePanel();
await dashboardCustomizePanel.expectCustomizePanelSettingsFlyoutOpen();
await dashboardCustomizePanel.enableCustomTimeRange();
await dashboardCustomizePanel.openDatePickerQuickMenu();
Expand Down Expand Up @@ -114,7 +113,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

const titles = await dashboard.getPanelTitles();
expect(titles[0]).to.be(`${visTitle} (converted)`);
await dashboardPanelActions.expectNotLinkedToLibrary(titles[0], true);
await panelActions.expectNotLinkedToLibrary(titles[0], true);
await dashboardBadgeActions.expectExistsTimeRangeBadgeAction();
await panelActions.removePanel();
});
Expand Down

0 comments on commit 2d78569

Please sign in to comment.