-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SIEM] Restores the _External alert count_ widget's subtitle (#62094)
## [SIEM] Restores the _External alert count_ widget's subtitle Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded ### Before  ### After 
- Loading branch information
1 parent
b06eaf4
commit 2cff8b4
Showing
3 changed files
with
158 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
x-pack/legacy/plugins/siem/public/pages/overview/alerts_by_category/index.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| /* eslint-disable react/display-name */ | ||
|
|
||
| import euiDarkVars from '@elastic/eui/dist/eui_theme_dark.json'; | ||
| import { mount, ReactWrapper } from 'enzyme'; | ||
| import React from 'react'; | ||
| import { ThemeProvider } from 'styled-components'; | ||
|
|
||
| import { useQuery } from '../../../containers/matrix_histogram'; | ||
| import { wait } from '../../../lib/helpers'; | ||
| import { mockIndexPattern, TestProviders } from '../../../mock'; | ||
|
|
||
| import { AlertsByCategory } from '.'; | ||
|
|
||
| jest.mock('../../../lib/kibana'); | ||
|
|
||
| jest.mock('../../../containers/matrix_histogram', () => { | ||
| return { | ||
| useQuery: jest.fn(), | ||
| }; | ||
| }); | ||
|
|
||
| const theme = () => ({ eui: { ...euiDarkVars, euiSizeL: '24px' }, darkMode: true }); | ||
| const from = new Date('2020-03-31T06:00:00.000Z').valueOf(); | ||
| const to = new Date('2019-03-31T06:00:00.000Z').valueOf(); | ||
|
|
||
| describe('Alerts by category', () => { | ||
| let wrapper: ReactWrapper; | ||
|
|
||
| describe('before loading data', () => { | ||
| beforeAll(async () => { | ||
| (useQuery as jest.Mock).mockReturnValue({ | ||
| data: null, | ||
| loading: false, | ||
| inspect: false, | ||
| totalCount: null, | ||
| }); | ||
|
|
||
| wrapper = mount( | ||
| <ThemeProvider theme={theme}> | ||
| <TestProviders> | ||
| <AlertsByCategory | ||
| deleteQuery={jest.fn()} | ||
| filters={[]} | ||
| from={from} | ||
| indexPattern={mockIndexPattern} | ||
| setQuery={jest.fn()} | ||
| to={to} | ||
| /> | ||
| </TestProviders> | ||
| </ThemeProvider> | ||
| ); | ||
|
|
||
| await wait(); | ||
| wrapper.update(); | ||
| }); | ||
|
|
||
| test('it renders the expected title', () => { | ||
| expect(wrapper.find('[data-test-subj="header-section-title"]').text()).toEqual( | ||
| 'External alert count' | ||
| ); | ||
| }); | ||
|
|
||
| test('it does NOT render the subtitle', () => { | ||
| expect(wrapper.find('[data-test-subj="header-panel-subtitle"]').exists()).toBe(false); | ||
| }); | ||
|
|
||
| test('it renders the expected filter fields', () => { | ||
| const expectedOptions = ['event.category', 'event.module']; | ||
|
|
||
| expectedOptions.forEach(option => { | ||
| expect(wrapper.find(`option[value="${option}"]`).text()).toEqual(option); | ||
| }); | ||
| }); | ||
|
|
||
| test('it renders the `View alerts` button', () => { | ||
| expect(wrapper.find('[data-test-subj="view-alerts"]').exists()).toBe(true); | ||
| }); | ||
|
|
||
| test('it does NOT render the bar chart when data is not available', () => { | ||
| expect(wrapper.find(`.echChart`).exists()).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('after loading data', () => { | ||
| beforeAll(async () => { | ||
| (useQuery as jest.Mock).mockReturnValue({ | ||
| data: [ | ||
| { x: 1, y: 2, g: 'g1' }, | ||
| { x: 2, y: 4, g: 'g1' }, | ||
| { x: 3, y: 6, g: 'g1' }, | ||
| { x: 1, y: 1, g: 'g2' }, | ||
| { x: 2, y: 3, g: 'g2' }, | ||
| { x: 3, y: 5, g: 'g2' }, | ||
| ], | ||
| loading: false, | ||
| inspect: false, | ||
| totalCount: 6, | ||
| }); | ||
|
|
||
| wrapper = mount( | ||
| <ThemeProvider theme={theme}> | ||
| <TestProviders> | ||
| <AlertsByCategory | ||
| deleteQuery={jest.fn()} | ||
| filters={[]} | ||
| from={from} | ||
| indexPattern={mockIndexPattern} | ||
| setQuery={jest.fn()} | ||
| to={to} | ||
| /> | ||
| </TestProviders> | ||
| </ThemeProvider> | ||
| ); | ||
|
|
||
| await wait(); | ||
| wrapper.update(); | ||
| }); | ||
|
|
||
| test('it renders the expected subtitle', () => { | ||
| expect(wrapper.find('[data-test-subj="header-panel-subtitle"]').text()).toEqual( | ||
| 'Showing: 6 external alerts' | ||
| ); | ||
| }); | ||
|
|
||
| test('it renders the bar chart when data is available', () => { | ||
| expect(wrapper.find(`.echChart`).exists()).toBe(true); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters