Tweak naming / add useCallback for handler

elastic · Feb 10, 2021 · 2c2f599 · 2c2f599
1 parent 07856b4
commit 2c2f599
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/.../pages/logs/log_entry_categories/sections/top_categories/analyze_dataset_in_ml_action.tsx b/.../pages/logs/log_entry_categories/sections/top_categories/analyze_dataset_in_ml_action.tsx
@@ -40,9 +40,8 @@ export const AnalyzeCategoryDatasetInMlAction: React.FunctionComponent<{
     },
   });
 
-  const mlLinkOnClick = useCallback(() => {
+  const handleClick = useCallback(() => {
     if (!viewAnomalyInMachineLearningLink) return;
-
     application.navigateToUrl(viewAnomalyInMachineLearningLink);
   }, [application, viewAnomalyInMachineLearningLink]);
 
@@ -53,7 +52,7 @@ export const AnalyzeCategoryDatasetInMlAction: React.FunctionComponent<{
         iconType="machineLearningApp"
         data-test-subj="analyzeCategoryDatasetInMlButton"
         href={viewAnomalyInMachineLearningLink}
-        onClick={mlLinkOnClick}
+        onClick={handleClick}
       />
     </EuiToolTip>
   );

diff --git a/...public/pages/logs/log_entry_categories/sections/top_categories/top_categories_section.tsx b/...public/pages/logs/log_entry_categories/sections/top_categories/top_categories_section.tsx
@@ -52,7 +52,7 @@ export const TopCategoriesSection: React.FunctionComponent<{
   changeSortOptions,
 }) => {
   const {
-    services: { ml, http, application },
+    services: { ml, http },
   } = useKibanaContextForPlugin();
 
   const analyzeInMlLink = useMlHref(ml, http.basePath.get(), {

diff --git a/...k/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/log_entry_example.tsx b/...k/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/log_entry_example.tsx
@@ -134,6 +134,11 @@ export const LogEntryExampleMessage: React.FunctionComponent<Props> = ({
     },
   });
 
+  const handleMlLinkClick = useCallback(() => {
+    if (!viewAnomalyInMachineLearningLink) return;
+    application.navigateToUrl(viewAnomalyInMachineLearningLink);
+  }, [viewAnomalyInMachineLearningLink, application]);
+
   const menuItems = useMemo(() => {
     if (!viewInStreamLinkProps.onClick || !viewAnomalyInMachineLearningLink) {
       return undefined;
@@ -153,7 +158,7 @@ export const LogEntryExampleMessage: React.FunctionComponent<Props> = ({
       },
       {
         label: VIEW_ANOMALY_IN_ML_LABEL,
-        onClick: () => application.navigateToUrl(viewAnomalyInMachineLearningLink),
+        onClick: handleMlLinkClick,
         href: viewAnomalyInMachineLearningLink,
       },
     ];
@@ -162,7 +167,7 @@ export const LogEntryExampleMessage: React.FunctionComponent<Props> = ({
     openLogEntryFlyout,
     viewInStreamLinkProps,
     viewAnomalyInMachineLearningLink,
-    application,
+    handleMlLinkClick,
   ]);
 
   return (