-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* Fix Lens Save and Return Removing Tags (#89613)
- Loading branch information
1 parent
e7d0ecd
commit 2beeccc
Showing
4 changed files
with
153 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import expect from '@kbn/expect'; | ||
| import { FtrProviderContext } from '../../ftr_provider_context'; | ||
|
|
||
| export default function ({ getService, getPageObjects }: FtrProviderContext) { | ||
| const listingTable = getService('listingTable'); | ||
| const testSubjects = getService('testSubjects'); | ||
| const esArchiver = getService('esArchiver'); | ||
| const retry = getService('retry'); | ||
| const find = getService('find'); | ||
| const dashboardVisualizations = getService('dashboardVisualizations'); | ||
| const dashboardPanelActions = getService('dashboardPanelActions'); | ||
| const PageObjects = getPageObjects([ | ||
| 'common', | ||
| 'tagManagement', | ||
| 'header', | ||
| 'dashboard', | ||
| 'visualize', | ||
| 'lens', | ||
| ]); | ||
|
|
||
| const lensTag = 'extreme-lens-tag'; | ||
| const lensTitle = 'lens tag test'; | ||
|
|
||
| describe('lens tagging', () => { | ||
| before(async () => { | ||
| await esArchiver.loadIfNeeded('logstash_functional'); | ||
| await esArchiver.loadIfNeeded('lens/basic'); | ||
| await PageObjects.common.navigateToApp('dashboard'); | ||
| await PageObjects.dashboard.preserveCrossAppState(); | ||
| await PageObjects.dashboard.clickNewDashboard(); | ||
| }); | ||
|
|
||
| it('adds a new tag to a Lens visualization', async () => { | ||
| // create lens | ||
| await dashboardVisualizations.ensureNewVisualizationDialogIsShowing(); | ||
| await PageObjects.visualize.clickLensWidget(); | ||
| await PageObjects.lens.goToTimeRange(); | ||
| await PageObjects.lens.configureDimension({ | ||
| dimension: 'lnsXY_xDimensionPanel > lns-empty-dimension', | ||
| operation: 'date_histogram', | ||
| field: '@timestamp', | ||
| }); | ||
| await PageObjects.lens.configureDimension({ | ||
| dimension: 'lnsXY_yDimensionPanel > lns-empty-dimension', | ||
| operation: 'avg', | ||
| field: 'bytes', | ||
| }); | ||
|
|
||
| await PageObjects.lens.configureDimension({ | ||
| dimension: 'lnsXY_splitDimensionPanel > lns-empty-dimension', | ||
| operation: 'terms', | ||
| field: 'ip', | ||
| }); | ||
|
|
||
| await PageObjects.header.waitUntilLoadingHasFinished(); | ||
| await testSubjects.click('lnsApp_saveButton'); | ||
|
|
||
| await PageObjects.visualize.setSaveModalValues(lensTitle, { | ||
| saveAsNew: false, | ||
| redirectToOrigin: true, | ||
| }); | ||
| await testSubjects.click('savedObjectTagSelector'); | ||
| await testSubjects.click(`tagSelectorOption-action__create`); | ||
|
|
||
| expect(await PageObjects.tagManagement.tagModal.isOpened()).to.be(true); | ||
|
|
||
| await PageObjects.tagManagement.tagModal.fillForm( | ||
| { | ||
| name: lensTag, | ||
| color: '#FFCC33', | ||
| description: '', | ||
| }, | ||
| { | ||
| submit: true, | ||
| } | ||
| ); | ||
|
|
||
| expect(await PageObjects.tagManagement.tagModal.isOpened()).to.be(false); | ||
| await testSubjects.click('confirmSaveSavedObjectButton'); | ||
| await retry.waitForWithTimeout('Save modal to disappear', 1000, () => | ||
| testSubjects | ||
| .missingOrFail('confirmSaveSavedObjectButton') | ||
| .then(() => true) | ||
| .catch(() => false) | ||
| ); | ||
| }); | ||
|
|
||
| it('retains its saved object tags after save and return', async () => { | ||
| await dashboardPanelActions.openContextMenu(); | ||
| await dashboardPanelActions.clickEdit(); | ||
| await PageObjects.lens.saveAndReturn(); | ||
| await PageObjects.header.waitUntilLoadingHasFinished(); | ||
|
|
||
| await PageObjects.visualize.gotoVisualizationLandingPage(); | ||
| await listingTable.waitUntilTableIsLoaded(); | ||
|
|
||
| // open the filter dropdown | ||
| const filterButton = await find.byCssSelector('.euiFilterGroup .euiFilterButton'); | ||
| await filterButton.click(); | ||
| await testSubjects.click( | ||
| `tag-searchbar-option-${PageObjects.tagManagement.testSubjFriendly(lensTag)}` | ||
| ); | ||
| // click elsewhere to close the filter dropdown | ||
| const searchFilter = await find.byCssSelector('main .euiFieldSearch'); | ||
| await searchFilter.click(); | ||
| // wait until the table refreshes | ||
| await listingTable.waitUntilTableIsLoaded(); | ||
| const itemNames = await listingTable.getAllItemsNames(); | ||
| expect(itemNames).to.contain(lensTitle); | ||
| }); | ||
| }); | ||
| } |