fix display of maps list (#27796)

* fix display of maps list * smap
elastic · Dec 27, 2018 · 2a1d5ec · 2a1d5ec
1 parent a3b4f68
commit 2a1d5ec
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/...core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap b/...core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap
@@ -83,7 +83,7 @@ exports[`after fetch initialFilter 1`] = `
             <EuiButton
               color="primary"
               data-test-subj="newDashboardLink"
-              fill={false}
+              fill={true}
               href="#/dashboard"
               iconSide="left"
               type="button"
@@ -333,7 +333,7 @@ exports[`after fetch renders table rows 1`] = `
             <EuiButton
               color="primary"
               data-test-subj="newDashboardLink"
-              fill={false}
+              fill={true}
               href="#/dashboard"
               iconSide="left"
               type="button"
@@ -501,7 +501,7 @@ exports[`after fetch renders warning when listingLimit is exceeded 1`] = `
             <EuiButton
               color="primary"
               data-test-subj="newDashboardLink"
-              fill={false}
+              fill={true}
               href="#/dashboard"
               iconSide="left"
               type="button"

diff --git a/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js b/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
@@ -522,6 +522,7 @@ class DashboardListingUi extends React.Component {
           <EuiButton
             href={`#${DashboardConstants.CREATE_NEW_DASHBOARD_URL}`}
             data-test-subj="newDashboardLink"
+            fill
           >
             <FormattedMessage
               id="kbn.dashboard.listing.createNewDashboardButtonLabel"

diff --git a/x-pack/plugins/gis/public/_main.scss b/x-pack/plugins/gis/public/_main.scss
@@ -1,5 +1,8 @@
-
-
+// Makes sure the listing page is full height with proper background
+map-listing, .gisListingPage {
+  display: flex;
+  flex-grow: 1;
+}
 
 
 #gis-plugin {

diff --git a/x-pack/plugins/gis/public/shared/components/map_listing.js b/x-pack/plugins/gis/public/shared/components/map_listing.js
@@ -322,6 +322,7 @@ export class MapListing extends React.Component {
           <EuiButton
             href={`#/map`}
             data-test-subj="newMapLink"
+            fill
           >
             Create new map
           </EuiButton>
@@ -372,8 +373,8 @@ export class MapListing extends React.Component {
 
   render() {
     return (
-      <EuiPage data-test-subj="gisListingPage" restrictWidth>
-        <EuiPageBody>
+      <EuiPage data-test-subj="gisListingPage" className="gisListingPage">
+        <EuiPageBody restrictWidth>
           {this.renderPageContent()}
         </EuiPageBody>
       </EuiPage>