simplify

elastic · May 3, 2023 · 29b9505 · 29b9505
1 parent 90c140d
commit 29b9505
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/x-pack/plugins/synthetics/server/alert_rules/status_rule/status_rule_executor.ts b/x-pack/plugins/synthetics/server/alert_rules/status_rule/status_rule_executor.ts
@@ -49,7 +49,6 @@ export class StatusRuleExecutor {
   monitors: Array<SavedObjectsFindResult<EncryptedSyntheticsMonitor>> = [];
 
   public locationIdNameMap: Record<string, string> = {};
-  public locationNameIdMap: Record<string, string> = {};
 
   constructor(
     previousStartedAt: Date | null,
@@ -76,12 +75,10 @@ export class StatusRuleExecutor {
 
     publicLocations.forEach((loc) => {
       this.locationIdNameMap[loc.label] = loc.id;
-      this.locationNameIdMap[loc.id] = loc.label;
     });
 
     privateLocations.forEach((loc) => {
       this.locationIdNameMap[loc.label] = loc.id;
-      this.locationIdNameMap[loc.id] = loc.label;
     });
   }
 
@@ -198,13 +195,10 @@ export class StatusRuleExecutor {
         delete downConfigs[locPlusId];
       } else {
         const { locations } = monitor.attributes;
-        if (
-          !locations.some(
-            (l) =>
-              l.label === downConfig.location ||
-              this.locationNameIdMap[l.id] === downConfig.location
-          )
-        ) {
+        const isLocationRemoved = !locations.some(
+          (l) => l.id === this.getLocationId(downConfig.location)
+        );
+        if (isLocationRemoved) {
           staleDownConfigs[locPlusId] = { ...downConfig, isLocationRemoved: true };
           delete downConfigs[locPlusId];
         }