Use es6 exports, replace module.exports (#12084)

* use es6 exports in fixtures

* use es6 exports in test_utils

* use es6 exports in src/ui

* use es6 exports in src/utils

* use es6 exports in src/server

* use es6 exports in timelion

* use es6 exports in core plugins, but not console

* use es6 exports in console

* use es6 exports in src/cli

* use eslint --fix for no-extra-semi rule

* selectively disable kibana-custom/no-default-export

* replace define() with exports

* clean up some object exports

in these cases, named exports are the better replacement

* use es6 exports in src/optimize, where possible

* fix uses of named exports

* fix some imports in console

* revert postcss optimizer to module.exports

* [timelion] put shared code in common directory

* fix url module export

don't export as default, rely on the named export

* convert define modules in src to export

* convert ui-bootstrap to cjs module

* lint webpackShims

no reason not to, they pass when the no-var rule is disabled

* fix new code not using es6 exports

* fix some straggling exports

src/cli/cluster/cluster_manager.js

@@ -7,7 +7,7 @@ import BasePathProxy from './base_path_proxy';
 
 process.env.kbnWorkerType = 'managr';
 
-module.exports = class ClusterManager {
+export default class ClusterManager {
   constructor(opts = {}, settings = {}) {
     this.log = new Log(opts.quiet, opts.silent);
     this.addedCount = 0;
@@ -169,4 +169,4 @@ module.exports = class ClusterManager {
     this.log.bad('failed to watch files!\n', err.stack);
     process.exit(1); // eslint-disable-line no-process-exit
   }
-};
+}

src/cli/cluster/worker.js

@@ -17,7 +17,7 @@ const dead = fork => {
   return fork.isDead() || fork.killed;
 };
 
-module.exports = class Worker extends EventEmitter {
+export default class Worker extends EventEmitter {
   constructor(opts) {
     opts = opts || {};
     super();
@@ -162,4 +162,4 @@ module.exports = class Worker extends EventEmitter {
     // wait for the fork to report it is online before resolving
     await new Promise(cb => this.once('fork:online', cb));
   }
-};
+}

src/cli/color.js

@@ -1,7 +1,6 @@
-
 import _ from 'lodash';
 import ansicolors from 'ansicolors';
 
-exports.green = _.flow(ansicolors.black, ansicolors.bgGreen);
-exports.red = _.flow(ansicolors.white, ansicolors.bgRed);
-exports.yellow = _.flow(ansicolors.black, ansicolors.bgYellow);
+export const green = _.flow(ansicolors.black, ansicolors.bgGreen);
+export const red = _.flow(ansicolors.white, ansicolors.bgRed);
+export const yellow = _.flow(ansicolors.black, ansicolors.bgYellow);

src/cli/command.js

@@ -91,4 +91,4 @@ Command.prototype.action = _.wrap(Command.prototype.action, function (action, fn
   });
 });
 
-module.exports = Command;
+export default Command;

src/cli/log.js

@@ -4,12 +4,12 @@ const log = _.restParam(function (color, label, rest1) {
   console.log.apply(console, [color(` ${_.trim(label)} `)].concat(rest1));
 });
 
-import color from './color';
+import { green, yellow, red } from './color';
 
-module.exports = class Log {
+export default class Log {
   constructor(quiet, silent) {
-    this.good = quiet || silent ? _.noop : _.partial(log, color.green);
-    this.warn = quiet || silent ? _.noop : _.partial(log, color.yellow);
-    this.bad = silent ? _.noop : _.partial(log, color.red);
+    this.good = quiet || silent ? _.noop : _.partial(log, green);
+    this.warn = quiet || silent ? _.noop : _.partial(log, yellow);
+    this.bad = silent ? _.noop : _.partial(log, red);
   }
-};
+}

src/cli/serve/serve.js

@@ -72,7 +72,7 @@ function readServerSettings(opts, extraCliOptions) {
   return settings;
 }
 
-module.exports = function (program) {
+export default function (program) {
   const command = program.command('serve');
 
   command
@@ -170,7 +170,7 @@ module.exports = function (program) {
 
     return kbnServer;
   });
-};
+}
 
 function logFatal(message, server) {
   if (server) {

src/core_plugins/console/api_server/api.js

@@ -42,4 +42,4 @@ function Api(name) {
 
 }(Api.prototype));
 
-module.exports = Api;
+export default Api;

src/core_plugins/console/api_server/es_5_0.js

@@ -53,4 +53,6 @@ ES_5_0.prototype = _.create(Api.prototype, { 'constructor': ES_5_0 });
   };
 })(ES_5_0.prototype);
 
-module.exports = new ES_5_0();
+const instance = new ES_5_0();
+
+export default instance;

src/core_plugins/console/api_server/es_5_0/aggregations.js

@@ -435,8 +435,9 @@ var rules = {
     }
   }
 };
-module.exports = function (api) {
+
+export default function (api) {
 
   api.addGlobalAutocompleteRules('aggregations', rules);
   api.addGlobalAutocompleteRules('aggs', rules);
-};
+}

src/core_plugins/console/api_server/es_5_0/aliases.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_post_aliases', {
     methods: ['POST'],
     patterns: [
@@ -68,4 +68,4 @@ module.exports = function (api) {
   api.addGlobalAutocompleteRules('aliases', {
     '*': aliasRules
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/cat.js

@@ -32,7 +32,7 @@ function addNodeattrsCat(api) {
   });
 }
 
-module.exports = function (api) {
+export default function (api) {
   addSimpleCat('_cat/aliases', api);
   addSimpleCat('_cat/allocation', api, null, ['_cat/allocation', '_cat/allocation/{nodes}']);
   addSimpleCat('_cat/count', api);
@@ -53,4 +53,4 @@ module.exports = function (api) {
   addSimpleCat('_cat/plugins', api);
   addSimpleCat('_cat/segments', api);
   addNodeattrsCat(api);
-};
+}

src/core_plugins/console/api_server/es_5_0/cluster.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_cluster/nodes/stats');
   api.addEndpointDescription('_cluster/state', {
     patterns: [
@@ -139,4 +139,4 @@ module.exports = function (api) {
       dry_run: { __one_of: [true, false] }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/count.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_count', {
       methods: ['GET', 'POST'],
       priority: 10, // collides with get doc by id
@@ -19,4 +19,4 @@ module.exports = function (api) {
         }
       }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/document.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_get_doc', {
     methods: ['GET'],
     patterns: [
@@ -230,4 +230,4 @@ module.exports = function (api) {
       }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/field_stats.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_field_stats', {
     methods: ['GET', 'POST'],
     patterns: [
@@ -44,4 +44,4 @@ module.exports = function (api) {
       }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/filter.js

@@ -330,7 +330,7 @@ filters.nested = {
   _name: ''
 };
 
-module.exports = function (api) {
+export default function (api) {
   api.addGlobalAutocompleteRules('filter', filters);
-};
+}
 

src/core_plugins/console/api_server/es_5_0/globals.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addGlobalAutocompleteRules('highlight', {
     pre_tags: {},
     post_tags: {},
@@ -21,4 +21,4 @@ module.exports = function (api) {
     lang: "",
     params: {}
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/indices.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_refresh', {
     methods: ['POST'],
     patterns: [
@@ -231,4 +231,4 @@ module.exports = function (api) {
       "{indices}/_open"
     ]
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/ingest.js

@@ -329,7 +329,7 @@ const simulateUrlParamsDefinition = {
   "verbose": "__flag__"
 };
 
-module.exports = function (api) {
+export default function (api) {
 
   // Note: this isn't an actual API endpoint. It exists so the forEach processor's "processor" field
   // may recursively use the autocomplete rules for any processor.
@@ -383,4 +383,4 @@ module.exports = function (api) {
       ]
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/mappings.js

@@ -4,7 +4,7 @@ var BOOLEAN = {
   __one_of: [true, false]
 };
 
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_get_mapping', {
     methods: ['GET'],
     priority: 10, // collides with get doc by id
@@ -216,4 +216,4 @@ module.exports = function (api) {
       }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/nodes.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_nodes/hot_threads', {
     methods: ['GET'],
     patterns: [
@@ -75,4 +75,4 @@ module.exports = function (api) {
       ]
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/percolator.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_put_percolator', {
     priority: 10, // to override doc
     methods: ['PUT', 'POST'],
@@ -87,4 +87,4 @@ module.exports = function (api) {
       filter: {}
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/query.js

@@ -67,7 +67,7 @@ var DECAY_FUNC_DESC = {
     }
   };
 
-module.exports = function (api) {
+export default function (api) {
   api.addGlobalAutocompleteRules('query', {
     match: {
       __template: {
@@ -624,4 +624,4 @@ module.exports = function (api) {
 
 
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/reindex.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
 
   api.addEndpointDescription('_post_reindex', {
     methods: [ 'POST' ],
@@ -54,4 +54,4 @@ module.exports = function (api) {
       'script': { __scope_link: 'GLOBAL.script' },
     }
   })
-};
+}

src/core_plugins/console/api_server/es_5_0/search.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_search', {
     methods: ['GET', 'POST'],
     priority: 10, // collides with get doc by id
@@ -252,4 +252,4 @@ module.exports = function (api) {
       local: "__flag__"
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/settings.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
 
   api.addEndpointDescription('_get_settings', {
     patterns: [
@@ -83,4 +83,4 @@ module.exports = function (api) {
       }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/snapshot_restore.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('restore_snapshot', {
     methods: ['POST'],
     patterns: [
@@ -126,4 +126,4 @@ module.exports = function (api) {
       }
     }
   });
-};
+}

src/core_plugins/console/api_server/es_5_0/templates.js

@@ -1,4 +1,4 @@
-module.exports = function (api) {
+export default function (api) {
   api.addEndpointDescription('_delete_template', {
     methods: ['DELETE'],
     patterns: [
@@ -24,4 +24,4 @@ module.exports = function (api) {
       settings: { __scope_link: '_put_settings' }
     }
   });
-};
+}

src/core_plugins/console/api_server/server.js

@@ -1,6 +1,6 @@
 let _ = require("lodash");
 
-module.exports.resolveApi = function (sense_version, apis, reply) {
+export function resolveApi(sense_version, apis, reply) {
   let result = {};
   _.each(apis, function (name) {
     {
@@ -11,4 +11,4 @@ module.exports.resolveApi = function (sense_version, apis, reply) {
   });
 
   return reply(result).type("application/json");
-};
+}

src/core_plugins/console/index.js

@@ -1,5 +1,5 @@
 import Boom from 'boom';
-import apiServer from './api_server/server';
+import { resolveApi } from './api_server/server';
 import { existsSync } from 'fs';
 import { resolve, join, sep } from 'path';
 import { has, isEmpty } from 'lodash';
@@ -109,7 +109,7 @@ export default function (kibana) {
             return;
           }
 
-          return apiServer.resolveApi(sense_version, apis.split(','), reply);
+          return resolveApi(sense_version, apis.split(','), reply);
         }
       });