Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
tiansivive committed Dec 18, 2023
1 parent a27e3b3 commit 2374e50
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
EuiModalHeaderTitle,
EuiSuperSelect,
EuiText,
EuiHorizontalRule,
} from '@elastic/eui';

import React, { useState } from 'react';
Expand Down Expand Up @@ -51,6 +52,7 @@ export const AssetCriticalitySelector: React.FC<Props> = ({ entity }) => {

return (
<>
<EuiHorizontalRule />
<EuiAccordion
id="asset-criticality-selector"
buttonContent={
Expand Down Expand Up @@ -113,6 +115,7 @@ export const AssetCriticalitySelector: React.FC<Props> = ({ entity }) => {
</EuiFlexGroup>
)}
</EuiAccordion>
<EuiHorizontalRule />
{modal.visible ? (
<AssetCriticalityModal entity={entity} criticality={criticality} modal={modal} />
) : null}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
EuiFlexItem,
EuiButtonIcon,
EuiSpacer,
EuiHorizontalRule,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React from 'react';
Expand Down Expand Up @@ -82,9 +81,7 @@ export const HostDetailsPanel: React.FC<HostDetailsProps> = React.memo(
<StyledEuiFlyoutBody>
<EuiSpacer size="m" />
<ExpandableHostDetailsPageLink hostName={hostName} />
<EuiHorizontalRule />
<AssetCriticalitySelector entity={{ type: 'host', name: hostName }} />
<EuiHorizontalRule />
<ExpandableHostDetails contextID={contextID} scopeId={scopeId} hostName={hostName} />
</StyledEuiFlyoutBody>
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { EuiFlyoutHeader, EuiFlyoutBody, EuiSpacer, EuiHorizontalRule } from '@elastic/eui';
import { EuiFlyoutHeader, EuiFlyoutBody, EuiSpacer } from '@elastic/eui';
import React from 'react';
import styled from 'styled-components';
import { AssetCriticalitySelector } from '../../../../entity_analytics/components/asset_criticality/asset_criticality_selector';
Expand Down Expand Up @@ -44,9 +44,7 @@ export const UserDetailsFlyout = ({
<StyledEuiFlyoutBody>
<EuiSpacer size="m" />
<ExpandableUserDetailsPageLink userName={userName} />
<EuiHorizontalRule />
<AssetCriticalitySelector entity={{ type: 'user', name: userName }} />
<EuiHorizontalRule />
<ExpandableUserDetails contextID={contextID} scopeId={scopeId} userName={userName} />
</StyledEuiFlyoutBody>
</>
Expand Down

0 comments on commit 2374e50

Please sign in to comment.