Fix types check

elastic · Nov 4, 2020 · 2303e80 · 2303e80
1 parent 3130434
commit 2303e80
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/x-pack/plugins/alerts/server/lib/alert_instance_summary_from_event_log.test.ts b/x-pack/plugins/alerts/server/lib/alert_instance_summary_from_event_log.test.ts
@@ -535,7 +535,7 @@ export class EventsFactory {
   }
 
   addActiveInstance(instanceId: string, actionGroupId: string | undefined): EventsFactory {
-    const kibanaAlerting = (actionGroupId)
+    const kibanaAlerting = actionGroupId
       ? { instance_id: instanceId, action_group_id: actionGroupId }
       : { instance_id: instanceId };
     this.events.push({

diff --git a/...ns_ui/public/application/sections/alert_details/components/alert_instances_route.test.tsx b/...ns_ui/public/application/sections/alert_details/components/alert_instances_route.test.tsx
@@ -8,7 +8,7 @@ import uuid from 'uuid';
 import { shallow } from 'enzyme';
 import { ToastsApi } from 'kibana/public';
 import { AlertInstancesRoute, getAlertInstanceSummary } from './alert_instances_route';
-import { Alert, AlertInstanceSummary } from '../../../../types';
+import { Alert, AlertInstanceSummary, AlertType } from '../../../../types';
 import { EuiLoadingSpinner } from '@elastic/eui';
 
 const fakeNow = new Date('2020-02-09T23:15:41.941Z');
@@ -23,10 +23,11 @@ jest.mock('../../../app_context', () => {
 describe('alert_instance_summary_route', () => {
   it('render a loader while fetching data', () => {
     const alert = mockAlert();
+    const alertType = mockAlertType();
 
     expect(
       shallow(
-        <AlertInstancesRoute readOnly={false} alert={alert} {...mockApis()} />
+        <AlertInstancesRoute readOnly={false} alert={alert} alertType={alertType} {...mockApis()} />
       ).containsMatchingElement(<EuiLoadingSpinner size="l" />)
     ).toBeTruthy();
   });
@@ -140,6 +141,23 @@ function mockAlert(overloads: Partial<Alert> = {}): Alert {
   };
 }
 
+function mockAlertType(overloads: Partial<AlertType> = {}): AlertType {
+  return {
+    id: 'test.testAlertType',
+    name: 'My Test Alert Type',
+    actionGroups: [{ id: 'default', name: 'Default Action Group' }],
+    actionVariables: {
+      context: [],
+      state: [],
+      params: [],
+    },
+    defaultActionGroupId: 'default',
+    authorizedConsumers: {},
+    producer: 'alerts',
+    ...overloads,
+  };
+}
+
 function mockAlertInstanceSummary(overloads: Partial<any> = {}): any {
   const summary: AlertInstanceSummary = {
     id: 'alert-id',