fix quick edit button tests

elastic · Nov 21, 2022 · 222d8e0 · 222d8e0
1 parent 0d9990e
commit 222d8e0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/...actions_ui/public/application/sections/common/components/rule_quick_edit_buttons.test.tsx b/...actions_ui/public/application/sections/common/components/rule_quick_edit_buttons.test.tsx
@@ -47,6 +47,8 @@ describe('rule_quick_edit_buttons', () => {
         selectedItems={[mockRule]}
         onPerformingAction={() => {}}
         onActionPerformed={() => {}}
+        onEnable={async () => {}}
+        onDisable={async () => {}}
         setRulesToDelete={() => {}}
         setRulesToDeleteFilter={() => {}}
         setRulesToUpdateAPIKey={() => {}}
@@ -62,8 +64,8 @@ describe('rule_quick_edit_buttons', () => {
       />
     );
 
-    expect(wrapper.find('[data-test-subj="enableAll"]').exists()).toBeFalsy();
-    expect(wrapper.find('[data-test-subj="disableAll"]').exists()).toBeTruthy();
+    expect(wrapper.find('[data-test-subj="bulkEnable"]').exists()).toBeTruthy();
+    expect(wrapper.find('[data-test-subj="bulkDisable"]').exists()).toBeTruthy();
     expect(wrapper.find('[data-test-subj="updateAPIKeys"]').exists()).toBeTruthy();
     expect(wrapper.find('[data-test-subj="bulkDelete"]').exists()).toBeTruthy();
     expect(wrapper.find('[data-test-subj="bulkSnooze"]').exists()).toBeTruthy();
@@ -85,6 +87,8 @@ describe('rule_quick_edit_buttons', () => {
         selectedItems={[mockRule]}
         onPerformingAction={() => {}}
         onActionPerformed={() => {}}
+        onEnable={async () => {}}
+        onDisable={async () => {}}
         setRulesToDelete={() => {}}
         setRulesToDeleteFilter={() => {}}
         setRulesToUpdateAPIKey={() => {}}
@@ -100,8 +104,8 @@ describe('rule_quick_edit_buttons', () => {
       />
     );
 
-    expect(wrapper.find('[data-test-subj="enableAll"]').exists()).toBeTruthy();
-    expect(wrapper.find('[data-test-subj="disableAll"]').exists()).toBeFalsy();
+    expect(wrapper.find('[data-test-subj="bulkEnable"]').exists()).toBeTruthy();
+    expect(wrapper.find('[data-test-subj="bulkDisable"]').exists()).toBeTruthy();
   });
 
   it('disables the disable/enable/delete bulk actions if in select all mode', async () => {
@@ -117,6 +121,8 @@ describe('rule_quick_edit_buttons', () => {
         selectedItems={[mockRule]}
         onPerformingAction={() => {}}
         onActionPerformed={() => {}}
+        onEnable={async () => {}}
+        onDisable={async () => {}}
         setRulesToDelete={() => {}}
         setRulesToDeleteFilter={() => {}}
         setRulesToUpdateAPIKey={() => {}}
@@ -132,7 +138,7 @@ describe('rule_quick_edit_buttons', () => {
       />
     );
 
-    expect(wrapper.find('[data-test-subj="disableAll"]').first().prop('isDisabled')).toBeTruthy();
+    expect(wrapper.find('[data-test-subj="bulkEnable"]').first().prop('isDisabled')).toBeFalsy();
     expect(wrapper.find('[data-test-subj="bulkDelete"]').first().prop('isDisabled')).toBeFalsy();
     expect(wrapper.find('[data-test-subj="updateAPIKeys"]').first().prop('isDisabled')).toBeFalsy();
     expect(wrapper.find('[data-test-subj="bulkSnooze"]').first().prop('isDisabled')).toBeFalsy();
@@ -159,6 +165,8 @@ describe('rule_quick_edit_buttons', () => {
         selectedItems={[mockRule]}
         onPerformingAction={() => {}}
         onActionPerformed={() => {}}
+        onEnable={async () => {}}
+        onDisable={async () => {}}
         setRulesToDelete={() => {}}
         setRulesToDeleteFilter={() => {}}
         setRulesToSnooze={setRulesToSnooze}
@@ -210,6 +218,8 @@ describe('rule_quick_edit_buttons', () => {
         selectedItems={[mockRule]}
         onPerformingAction={() => {}}
         onActionPerformed={() => {}}
+        onEnable={async () => {}}
+        onDisable={async () => {}}
         setRulesToDelete={() => {}}
         setRulesToDeleteFilter={() => {}}
         setRulesToSnooze={setRulesToSnooze}

diff --git a/...gers_actions_ui/public/application/sections/common/components/rule_quick_edit_buttons.tsx b/...gers_actions_ui/public/application/sections/common/components/rule_quick_edit_buttons.tsx
@@ -295,7 +295,7 @@ export const RuleQuickEditButtons: React.FunctionComponent<ComponentOpts> = ({
           onClick={onEnable}
           isLoading={isEnablingRules}
           isDisabled={isPerformingAction || hasDisabledByLicenseRuleTypes}
-          data-test-subj="enableAll"
+          data-test-subj="bulkEnable"
         >
           <FormattedMessage
             id="xpack.triggersActionsUI.sections.rulesList.bulkActionPopover.enableAllTitle"
@@ -308,7 +308,7 @@ export const RuleQuickEditButtons: React.FunctionComponent<ComponentOpts> = ({
           onClick={onDisable}
           isLoading={isDisablingRules}
           isDisabled={isPerformingAction || hasDisabledByLicenseRuleTypes}
-          data-test-subj="disableAll"
+          data-test-subj="bulkDisable"
         >
           <FormattedMessage
             id="xpack.triggersActionsUI.sections.rulesList.bulkActionPopover.disableAllTitle"