Skip to content

Commit

Permalink
unskipp test suite, improve the wait()
Browse files Browse the repository at this point in the history
  • Loading branch information
MiriamAparicio committed Oct 24, 2024
1 parent 9aa67ef commit 21ed69f
Showing 1 changed file with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ const mainApiRequestsToIntercept = [
];

const mainAliasNames = mainApiRequestsToIntercept.map(({ aliasName }) => `@${aliasName}`);
// flaky test
describe.skip('Storage Explorer', () => {

describe('Storage Explorer', () => {
before(() => {
const { rangeFrom, rangeTo } = timeRange;
synthtrace.index(
Expand Down Expand Up @@ -111,11 +111,10 @@ describe.skip('Storage Explorer', () => {

cy.loginAsMonitorUser();
cy.visitKibana(storageExplorerHref);
cy.wait(mainAliasNames);
});

it('with the correct environment when changing the environment', () => {
cy.wait(mainAliasNames);

cy.getByTestSubj('environmentFilter').type('{selectall}production');

cy.contains('button', 'production').click({ force: true });
Expand All @@ -127,19 +126,14 @@ describe.skip('Storage Explorer', () => {
});

it('when selecting a different time range and clicking the update button', () => {
cy.wait(mainAliasNames);

cy.selectAbsoluteTimeRange(
moment(timeRange.rangeFrom).subtract(5, 'm').toISOString(),
moment(timeRange.rangeTo).subtract(5, 'm').toISOString()
);
cy.contains('Update').click();
cy.wait(mainAliasNames);
});

it('with the correct lifecycle phase when changing the lifecycle phase', () => {
cy.wait(mainAliasNames);

cy.getByTestSubj('storageExplorerLifecyclePhaseSelect').click();
cy.contains('button', 'Warm').click();

Expand All @@ -166,10 +160,10 @@ describe.skip('Storage Explorer', () => {

cy.loginAsMonitorUser();
cy.visitKibana(storageExplorerHref);
cy.wait(mainAliasNames);
});

it('shows storage details', () => {
cy.wait(mainAliasNames);
cy.contains('opbeans-node');

cy.getByTestSubj('storageDetailsButton_opbeans-node').click();
Expand Down

0 comments on commit 21ed69f

Please sign in to comment.