Skip to content

Commit

Permalink
Merge branch 'master' into feature-rename-ingestmanager-fleet-tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kibanamachine authored Nov 12, 2020
2 parents 76d39b8 + b8576ed commit 217a03f
Show file tree
Hide file tree
Showing 20 changed files with 213 additions and 228 deletions.
99 changes: 0 additions & 99 deletions docs/settings/ssl-settings.asciidoc

This file was deleted.

13 changes: 6 additions & 7 deletions src/core/public/chrome/ui/header/header_breadcrumbs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { EuiHeaderBreadcrumbs } from '@elastic/eui';
import { EuiFlexGroup, EuiHeaderBreadcrumbs } from '@elastic/eui';
import classNames from 'classnames';
import React from 'react';
import useObservable from 'react-use/lib/useObservable';
Expand Down Expand Up @@ -51,15 +51,14 @@ export function HeaderBreadcrumbs({ appTitle$, breadcrumbs$, breadcrumbsAppendEx
),
}));

if (breadcrumbsAppendExtension) {
if (breadcrumbsAppendExtension && crumbs[crumbs.length - 1]) {
const lastCrumb = crumbs[crumbs.length - 1];
lastCrumb.text = (
<>
{lastCrumb.text}
<HeaderExtension extension={breadcrumbsAppendExtension.content} display={'inlineBlock'} />
</>
<EuiFlexGroup responsive={false} gutterSize={'none'} alignItems={'baseline'}>
<div className="eui-textTruncate">{lastCrumb.text}</div>
<HeaderExtension extension={breadcrumbsAppendExtension.content} />
</EuiFlexGroup>
);
}

return <EuiHeaderBreadcrumbs breadcrumbs={crumbs} max={10} data-test-subj="breadcrumbs" />;
}
10 changes: 3 additions & 7 deletions test/functional/apps/discover/_doc_navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,19 @@
import expect from '@kbn/expect';

export default function ({ getService, getPageObjects }) {
const log = getService('log');
const docTable = getService('docTable');
const filterBar = getService('filterBar');
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common', 'discover', 'timePicker', 'context']);
const esArchiver = getService('esArchiver');
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/78373
describe.skip('doc link in discover', function contextSize() {
describe('doc link in discover', function contextSize() {
beforeEach(async function () {
log.debug('load kibana index with default index pattern');
await esArchiver.loadIfNeeded('discover');

await esArchiver.loadIfNeeded('logstash_functional');
await esArchiver.loadIfNeeded('discover');
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.discover.waitForDocTableLoadingComplete();
});

Expand Down
3 changes: 1 addition & 2 deletions test/functional/apps/discover/_field_data.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ export default function ({ getService, getPageObjects }) {
const queryBar = getService('queryBar');
const PageObjects = getPageObjects(['common', 'header', 'discover', 'visualize', 'timePicker']);

// FLAKY: https://github.com/elastic/kibana/issues/78689
describe.skip('discover tab', function describeIndexTests() {
describe('discover tab', function describeIndexTests() {
this.tags('includeFirefox');
before(async function () {
await esArchiver.loadIfNeeded('logstash_functional');
Expand Down
3 changes: 1 addition & 2 deletions test/functional/apps/discover/_inspector.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ export default function ({ getService, getPageObjects }) {
return hitsCountStatsRow[STATS_ROW_VALUE_INDEX];
}

// FLAKY: https://github.com/elastic/kibana/issues/39842
describe.skip('inspect', () => {
describe('inspect', () => {
before(async () => {
await esArchiver.loadIfNeeded('logstash_functional');
await esArchiver.load('discover');
Expand Down
Loading

0 comments on commit 217a03f

Please sign in to comment.