remove linting rule exception for markdown

elastic · Jan 8, 2020 · 2098b63 · 2098b63
1 parent 8eb000d
commit 2098b63
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -95,12 +95,6 @@ module.exports = {
         'react-hooks/exhaustive-deps': 'off',
       },
     },
-    {
-      files: ['src/legacy/core_plugins/vis_type_markdown/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['src/legacy/core_plugins/vis_type_metric/**/*.{js,ts,tsx}'],
       rules: {

diff --git a/src/legacy/core_plugins/vis_type_markdown/public/markdown_options.tsx b/src/legacy/core_plugins/vis_type_markdown/public/markdown_options.tsx
@@ -36,7 +36,7 @@ import { MarkdownVisParams } from './types';
 function MarkdownOptions({ stateParams, setValue }: VisOptionsProps<MarkdownVisParams>) {
   const onMarkdownUpdate = useCallback(
     (value: MarkdownVisParams['markdown']) => setValue('markdown', value),
-    []
+    [setValue]
   );
 
   return (