Skip to content

Commit

Permalink
[Lens] Unskip functional test error (#176885)
Browse files Browse the repository at this point in the history
  • Loading branch information
kertal authored Feb 16, 2024
1 parent c35dcfe commit 1f93119
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 10 deletions.
19 changes: 13 additions & 6 deletions x-pack/test/functional/apps/lens/group2/fields_list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@ import expect from '@kbn/expect';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['visualize', 'lens', 'common', 'header', 'timePicker']);
const PageObjects = getPageObjects([
'visualize',
'lens',
'common',
'header',
'timePicker',
'unifiedFieldList',
]);
const find = getService('find');
const log = getService('log');
const testSubjects = getService('testSubjects');
Expand All @@ -19,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const es = getService('es');
const queryBar = getService('queryBar');

// Failing: See https://github.com/elastic/kibana/issues/176837
describe.skip('lens fields list tests', () => {
describe('lens fields list tests', () => {
for (const datasourceType of ['form-based', 'ad-hoc', 'ad-hoc-no-timefield']) {
describe(`${datasourceType} datasource`, () => {
before(async () => {
Expand Down Expand Up @@ -263,16 +269,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should show new fields Available fields', async () => {
await es.transport.request({
path: '/field-update-test/_doc',
path: '/field-update-test/_doc?refresh=true',
method: 'POST',
body: {
'@timestamp': new Date().toISOString(),
oldField: 10,
oldField: 20,
newField: 20,
},
});

await PageObjects.lens.waitForField('oldField');
await queryBar.setQuery('oldField: 10');
await queryBar.setQuery('oldField: 20');
await queryBar.submitQuery();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.lens.waitForField('newField');
Expand Down
15 changes: 11 additions & 4 deletions x-pack/test/functional/apps/lens/group4/show_underlying_data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,22 @@ import expect from '@kbn/expect';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['visualize', 'lens', 'common', 'header', 'discover']);
const PageObjects = getPageObjects([
'visualize',
'lens',
'common',
'header',
'discover',
'unifiedFieldList',
]);
const queryBar = getService('queryBar');
const filterBar = getService('filterBar');
const listingTable = getService('listingTable');
const testSubjects = getService('testSubjects');
const find = getService('find');
const browser = getService('browser');

// Failing: See https://github.com/elastic/kibana/issues/176828
describe.skip('show underlying data', () => {
describe('show underlying data', () => {
it('should show the open button for a compatible saved visualization', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
await listingTable.searchForItemWithName('lnsXYvis');
Expand Down Expand Up @@ -126,7 +132,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('should show the open button for a compatible saved visualization with a lucene query', async () => {
// Make the breakdown dimention contribute to filters again
// Make the breakdown dimension contribute to filters again
await PageObjects.lens.openDimensionEditor(
'lnsXY_splitDimensionPanel > lns-dimensionTrigger'
);
Expand Down Expand Up @@ -155,6 +161,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const [lensWindowHandler, discoverWindowHandle] = await browser.getAllWindowHandles();
await browser.switchToWindow(discoverWindowHandle);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
await testSubjects.existOrFail('unifiedHistogramChart');
// check the query
expect(await queryBar.getQueryString()).be.eql(
Expand Down

0 comments on commit 1f93119

Please sign in to comment.