[Synthetics/Uptime] Better code separation (#160245)

Co-authored-by: kibanamachine <[email protected]>

.buildkite/ftr_configs.yml

@@ -55,7 +55,7 @@ disabled:
 
   # Elastic Synthetics configs
   - x-pack/plugins/synthetics/e2e/config.ts
-  - x-pack/plugins/synthetics/e2e/uptime/synthetics_run.ts
+  - x-pack/plugins/uptime/e2e/uptime/synthetics_run.ts
   - x-pack/plugins/synthetics/e2e/synthetics/synthetics_run.ts
   - x-pack/plugins/ux/e2e/synthetics_run.ts
   - x-pack/plugins/exploratory_view/e2e/synthetics_run.ts

.buildkite/scripts/steps/functional/uptime_plugin.sh

@@ -13,4 +13,4 @@ echo "--- Uptime plugin @elastic/synthetics Tests"
 
 cd "$XPACK_DIR"
 
-node plugins/synthetics/scripts/uptime_e2e.js --kibana-install-dir "$KIBANA_BUILD_LOCATION" ${GREP:+--grep \"${GREP}\"}
+node plugins/uptime/scripts/uptime_e2e.js --kibana-install-dir "$KIBANA_BUILD_LOCATION" ${GREP:+--grep \"${GREP}\"}

.github/CODEOWNERS

@@ -726,6 +726,7 @@ examples/unified_field_list_examples @elastic/kibana-data-discovery
 src/plugins/unified_histogram @elastic/kibana-data-discovery
 src/plugins/unified_search @elastic/kibana-visualizations
 x-pack/plugins/upgrade_assistant @elastic/platform-deployment-management
+x-pack/plugins/uptime @elastic/uptime
 x-pack/plugins/drilldowns/url_drilldown @elastic/kibana-app-services
 src/plugins/url_forwarding @elastic/kibana-visualizations
 packages/kbn-url-state @elastic/security-threat-hunting-investigations

docs/developer/plugin-list.asciidoc

@@ -800,6 +800,11 @@ As a developer you can reuse and extend built-in alerts and actions UI functiona
 |Upgrade Assistant helps users prepare their Stack for being upgraded to the next version of the Elastic stack.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/uptime/README.md[uptime]
+|The purpose of this plugin is to provide users of Heartbeat more visibility of what's happening
+in their infrastructure.
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/drilldowns/url_drilldown/README.md[urlDrilldown]
 |NOTE: This plugin contains implementation of URL drilldown. For drilldowns infrastructure code refer to ui_actions_enhanced plugin.
 

package.json

@@ -716,6 +716,7 @@
     "@kbn/unified-histogram-plugin": "link:src/plugins/unified_histogram",
     "@kbn/unified-search-plugin": "link:src/plugins/unified_search",
     "@kbn/upgrade-assistant-plugin": "link:x-pack/plugins/upgrade_assistant",
+    "@kbn/uptime-plugin": "link:x-pack/plugins/uptime",
     "@kbn/url-drilldown-plugin": "link:x-pack/plugins/drilldowns/url_drilldown",
     "@kbn/url-forwarding-plugin": "link:src/plugins/url_forwarding",
     "@kbn/url-state": "link:packages/kbn-url-state",

packages/kbn-babel-preset/styled_components_files.js

@@ -14,7 +14,7 @@ module.exports = {
   USES_STYLED_COMPONENTS: [
     /packages[\/\\]kbn-ui-shared-deps-(npm|src)[\/\\]/,
     /src[\/\\]plugins[\/\\](kibana_react)[\/\\]/,
-    /x-pack[\/\\]plugins[\/\\](apm|beats_management|cases|fleet|infra|lists|observability|observability_shared|exploratory_view|osquery|security_solution|timelines|synthetics|ux)[\/\\]/,
+    /x-pack[\/\\]plugins[\/\\](apm|beats_management|cases|fleet|infra|lists|observability|observability_shared|exploratory_view|osquery|security_solution|timelines|synthetics|ux|uptime)[\/\\]/,
     /x-pack[\/\\]test[\/\\]plugin_functional[\/\\]plugins[\/\\]resolver_test[\/\\]/,
     /x-pack[\/\\]packages[\/\\]elastic_assistant[\/\\]/,
     /x-pack[\/\\]packages[\/\\]security-solution[\/\\]ecs_data_quality_dashboard[\/\\]/,

packages/kbn-optimizer/limits.yml

@@ -140,6 +140,7 @@ pageLoadAssetSize:
   unifiedHistogram: 19928
   unifiedSearch: 71059
   upgradeAssistant: 81241
+  uptime: 37842
   urlDrilldown: 30063
   urlForwarding: 32579
   usageCollection: 39762

tsconfig.base.json

@@ -1446,6 +1446,8 @@
       "@kbn/unified-search-plugin/*": ["src/plugins/unified_search/*"],
       "@kbn/upgrade-assistant-plugin": ["x-pack/plugins/upgrade_assistant"],
       "@kbn/upgrade-assistant-plugin/*": ["x-pack/plugins/upgrade_assistant/*"],
+      "@kbn/uptime-plugin": ["x-pack/plugins/uptime"],
+      "@kbn/uptime-plugin/*": ["x-pack/plugins/uptime/*"],
       "@kbn/url-drilldown-plugin": ["x-pack/plugins/drilldowns/url_drilldown"],
       "@kbn/url-drilldown-plugin/*": ["x-pack/plugins/drilldowns/url_drilldown/*"],
       "@kbn/url-forwarding-plugin": ["src/plugins/url_forwarding"],

x-pack/.i18nrc.json

@@ -87,6 +87,7 @@
     "xpack.upgradeAssistant": "plugins/upgrade_assistant",
     "xpack.synthetics": ["plugins/synthetics"],
     "xpack.ux": ["plugins/ux"],
+    "xpack.uptime": ["plugins/uptime"],
     "xpack.urlDrilldown": "plugins/drilldowns/url_drilldown",
     "xpack.watcher": "plugins/watcher"
   },

x-pack/plugins/synthetics/common/requests/get_certs_request_body.ts

@@ -7,10 +7,10 @@
 
 import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
 import DateMath from '@kbn/datemath';
+import type { CertificatesResults } from '../../server/queries/get_certs';
 import { CertResult, GetCertsParams, Ping } from '../runtime_types';
 import { createEsQuery } from '../utils/es_search';
 
-import type { CertificatesResults } from '../../server/legacy_uptime/lib/requests/get_certs';
 import { asMutableArray } from '../utils/as_mutable_array';
 
 enum SortFields {

x-pack/plugins/synthetics/e2e/synthetics/journeys/alert_rules/default_status_alert.journey.ts

@@ -9,8 +9,8 @@ import { journey, step, before, after, expect } from '@elastic/synthetics';
 import { byTestId } from '@kbn/ux-plugin/e2e/journeys/utils';
 import { RetryService } from '@kbn/ftr-common-functional-services';
 import { v4 as uuidv4 } from 'uuid';
+import { getReasonMessage } from '../../../../server/alert_rules/status_rule/message_utils';
 import { recordVideo } from '../../../helpers/record_video';
-import { getReasonMessage } from '../../../../server/legacy_uptime/lib/alerts/status_check';
 import { syntheticsAppPageProvider } from '../../page_objects/synthetics_app';
 import { SyntheticsServices } from '../services/synthetics_services';
 

x-pack/plugins/synthetics/kibana.jsonc

@@ -30,13 +30,11 @@
       "taskManager",
       "triggersActionsUi",
       "usageCollection",
-      "unifiedSearch",
       "bfetch"
     ],
     "optionalPlugins": ["cloud", "data", "fleet", "home", "ml", "spaces", "telemetry"],
     "requiredBundles": [
       "data",
-      "unifiedSearch",
       "fleet",
       "kibanaReact",
       "kibanaUtils",
@@ -45,4 +43,4 @@
       "indexLifecycleManagement"
     ]
   }
-}
+}