Skip to content

Commit

Permalink
[8.0][Fleet] Re-enable registry version check (#120049)
Browse files Browse the repository at this point in the history
* Re-enable registry version check

* Update registry image

* Use dockerized registry for base x-pack api integration and functional tests

* Revert "Use dockerized registry for base x-pack api integration and functional tests"

This reverts commit 2fd4ec1.

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
jen-huang and kibanamachine authored Dec 2, 2021
1 parent e829d98 commit 1ab415e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/ftr_e2e/ftr_config_run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { packageRegistryPort } from './ftr_config';
import { FtrProviderContext } from './ftr_provider_context';

export const dockerImage =
'docker.elastic.co/package-registry/distribution@sha256:13d9996dd24161624784704e080f5f5b7f0ef34ff0d9259f8f05010ccae00058';
'docker.elastic.co/package-registry/distribution@sha256:de952debe048d903fc73e8a4472bb48bb95028d440cba852f21b863d47020c61';

async function ftrConfigRun({ readConfigFile }: FtrConfigProviderContext) {
const kibanaConfig = await readConfigFile(require.resolve('./ftr_config.ts'));
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/fleet/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ export const config: PluginConfigDescriptor = {
outputs: PreconfiguredOutputsSchema,
agentIdVerificationEnabled: schema.boolean({ defaultValue: true }),
developer: schema.object({
// TODO: change default to false as soon as EPR issue fixed. Blocker for 8.0.
disableRegistryVersionCheck: schema.boolean({ defaultValue: true }),
disableRegistryVersionCheck: schema.boolean({ defaultValue: false }),
}),
}),
};
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/fleet/server/services/epm/registry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,8 @@ export async function fetchFile(filePath: string): Promise<Response> {
}

function setKibanaVersion(url: URL) {
// TODO: change default to false as soon as EPR issue fixed. Blocker for 8.0.
const disableVersionCheck =
appContextService.getConfig()?.developer?.disableRegistryVersionCheck ?? true;
appContextService.getConfig()?.developer?.disableRegistryVersionCheck ?? false;
if (disableVersionCheck) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/fleet_api_integration/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { defineDockerServersConfig } from '@kbn/test';
// example: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fpackage-storage/detail/snapshot/74/pipeline/257#step-302-log-1.
// It should be updated any time there is a new Docker image published for the Snapshot Distribution of the Package Registry.
export const dockerImage =
'docker.elastic.co/package-registry/distribution@sha256:13d9996dd24161624784704e080f5f5b7f0ef34ff0d9259f8f05010ccae00058';
'docker.elastic.co/package-registry/distribution@sha256:de952debe048d903fc73e8a4472bb48bb95028d440cba852f21b863d47020c61';

export default async function ({ readConfigFile }: FtrConfigProviderContext) {
const xPackAPITestsConfig = await readConfigFile(require.resolve('../api_integration/config.ts'));
Expand Down

0 comments on commit 1ab415e

Please sign in to comment.