fix css and add to migration doc

elastic · Nov 15, 2019 · 1a69978 · 1a69978
1 parent f8add37
commit 1a69978
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/src/core/MIGRATION.md b/src/core/MIGRATION.md
@@ -1130,7 +1130,7 @@ import { setup, start } from '../core_plugins/visualizations/public/legacy';
 | ------------------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------ |
 | `import 'ui/apply_filters'`                       | `import { ApplyFiltersPopover } from '../data/public'`       | `import '../data/public/legacy` should be called to load legacy directives                                                                                   |
 | `import 'ui/filter_bar'`                          | `import { FilterBar } from '../data/public'`                 | `import '../data/public/legacy` should be called to load legacy directives                                                                                   |
-| `import 'ui/query_bar'`                           | `import { QueryBarInput } from '../data/public'`   | Directives are deprecated.                                                                                                                                   |
+| `import 'ui/query_bar'`                           | `import { QueryBarInput } from '../data/public'`   | Directives are deprecated.                                                                                                                                             |
 | `import 'ui/search_bar'`                          | `import { SearchBar } from '../data/public'`                 | Directive is deprecated.                                                                                                                                     |
 | `import 'ui/kbn_top_nav'`                         | `import { TopNavMenu } from '../navigation/public'`          | Directive is still available in `ui/kbn_top_nav`.                                                                                                            |
 | `ui/saved_objects/components/saved_object_finder` | `import { SavedObjectFinder } from '../kibana_react/public'` |                                                                                                                                                              |
@@ -1142,6 +1142,7 @@ import { setup, start } from '../core_plugins/visualizations/public/legacy';
 | `ui/registry/feature_catalogue                    | `feature_catalogue.register`                                 | Must add `feature_catalogue` as a dependency in your kibana.json.                                                                                            |
 | `ui/registry/vis_types`                           | `visualizations.types`                                       | --                                                                                                                                                           |
 | `ui/vis`                                          | `visualizations.types`                                       | --                                                                                                                                                           |
+| `ui/share`                                        | `share`                                                      | `showShareContextMenu` is now called `toggleShareContextMenu`, `ShareContextMenuExtensionsRegistryProvider` is now called `register`                         |
 | `ui/vis/vis_factory`                              | `visualizations.types`                                       | --                                                                                                                                                           |
 | `ui/vis/vis_filters`                              | `visualizations.filters`                                     | --                                                                                                                                                           |
 | `ui/utils/parse_es_interval`                      | `import { parseEsInterval } from '../data/public'`           | `parseEsInterval`, `ParsedInterval`, `InvalidEsCalendarIntervalError`, `InvalidEsIntervalFormatError` items were moved to the `Data Plugin` as a static code |

diff --git a/src/legacy/ui/public/share/_share_context_menu.scss b/src/legacy/ui/public/share/_share_context_menu.scss
@@ -1,8 +1,3 @@
 .kbnShareContextMenu__finalPanel {
   padding: $euiSize;
 }
-
-.kbnShareContextMenu__copyAnchor,
-.kbnShareContextMenu__copyButton {
-  width: 100%;
-}
diff --git a/src/plugins/share/public/components/url_panel_content.tsx b/src/plugins/share/public/components/url_panel_content.tsx
@@ -105,13 +105,11 @@ export class UrlPanelContent extends Component<Props, State> {
 
           <EuiSpacer size="m" />
 
-          <EuiCopy
-            textToCopy={this.state.url || ''}
-            anchorClassName="kbnShareContextMenu__copyAnchor"
-          >
+          <EuiCopy textToCopy={this.state.url || ''} anchorClassName="eui-displayBlock">
             {(copy: () => void) => (
               <EuiButton
                 fill
+                fullWidth
                 onClick={copy}
                 disabled={this.state.isCreatingShortUrl || this.state.url === ''}
                 data-share-url={this.state.url}

diff --git a/x-pack/legacy/plugins/reporting/public/components/reporting_panel_content.tsx b/x-pack/legacy/plugins/reporting/public/components/reporting_panel_content.tsx
@@ -127,12 +127,9 @@ class ReportingPanelContentUi extends Component<Props, State> {
         </EuiText>
         <EuiSpacer size="s" />
 
-        <EuiCopy
-          textToCopy={this.state.absoluteUrl}
-          anchorClassName="kbnShareContextMenu__copyAnchor"
-        >
+        <EuiCopy textToCopy={this.state.absoluteUrl} anchorClassName="eui-displayBlock">
           {copy => (
-            <EuiButton className="kbnShareContextMenu__copyButton" onClick={copy} size="s">
+            <EuiButton fullWidth onClick={copy} size="s">
               <FormattedMessage
                 id="xpack.reporting.panelContent.copyUrlButtonLabel"
                 defaultMessage="Copy POST URL"
@@ -147,8 +144,8 @@ class ReportingPanelContentUi extends Component<Props, State> {
   private renderGenerateReportButton = (isDisabled: boolean) => {
     return (
       <EuiButton
-        className="kbnShareContextMenu__copyButton"
         disabled={isDisabled}
+        fullWidth
         fill
         onClick={this.createReportingJob}
         data-test-subj="generateReportButton"