Merge remote-tracking branch 'upstream/master' into ingest/rename-dat…

…asources

docs/apm/troubleshooting.asciidoc

@@ -10,6 +10,11 @@ your proposed changes at https://github.com/elastic/kibana.
 
 Also, check out the https://discuss.elastic.co/c/apm[APM discussion forum].
 
+* <<no-apm-data-found>>
+* <<troubleshooting-too-many-transactions>>
+* <<troubleshooting-unknown-route>>
+* <<troubleshooting-fields-unsearchable>>
+
 [float]
 [[no-apm-data-found]]
 === No APM data found
@@ -58,6 +63,66 @@ Navigate to *APM* > *Settings* > *Indices*, and change all `apm_oss.*Pattern` va
 include the new index pattern. For example: `customIndexName-*`.
 
 [float]
+[[troubleshooting-too-many-transactions]]
+=== Too many unique transaction names
+
+Transaction names are defined in each APM Agent; when an Agent supports a framework,
+it includes logic for naming the transactions that the framework creates.
+In some cases though, like when using an Agent's API to create custom transactions,
+it is up to the user to define a pattern for transaction naming.
+When transactions are named incorrectly, each unique URL can be associated with a unique transaction group—causing
+an explosion in the number of transaction groups per service, and leading to inaccuracies in the APM app.
+
+To fix a large number of unique transaction names,
+you need to change how you are using the Agent API to name your transactions.
+To do this, ensure you are **not** naming based on parameters that can change.
+For example, user ids, product ids, order numbers, query parameters, etc.,
+should be stripped away, and commonality should be found between your unique URLs.
+
+Let's look at an example from the RUM Agent documentation. Here are a few URLs you might find on Elastic.co:
+
+[source,yml]
+----
+// Blog Posts
+https://www.elastic.co/blog/reflections-on-three-years-in-the-elastic-public-sector
+https://www.elastic.co/blog/say-heya-to-the-elastic-search-awards
+https://www.elastic.co/blog/and-the-winner-of-the-elasticon-2018-training-subscription-drawing-is
+
+// Documentation
+https://www.elastic.co/guide/en/elastic-stack/current/index.html
+https://www.elastic.co/guide/en/apm/get-started/current/index.html
+https://www.elastic.co/guide/en/infrastructure/guide/current/index.html
+----
+
+These URLs, like most, include unique names.
+If we named transactions based on each unique URL, we'd end up with the problem described above—a
+very large number of different transaction names.
+Instead, we should strip away the unique information and group our transactions based on common information.
+In this case, that means naming all blog transactions, `/blog`, and all documentation transactions, `/guide`.
+
+If you feel like you'd be losing valuable information by following this naming convention, don't fret!
+You can always add additional metadata to your transactions using {apm-overview-ref-v}/metadata.html#labels-fields[labels] (indexed) or
+{apm-overview-ref-v}/metadata.html#custom-fields[custom context] (non-indexed).
+
+After ensuring you've correctly named your transactions,
+you might still see an error in the APM app related to too many transaction names.
+If this is the case, you can increase the default number of transaction groups displayed in the APM app by configuring
+<<apm-settings-kb,`xpack.apm.ui.transactionGroupBucketSize`>>.
+
+**More information**
+
+While this can happen with any APM Agent, it typically occurs with the RUM Agent.
+For more information on how to correctly set `transaction.name` in the RUM Agent,
+see {apm-rum-ref}/custom-transaction-name.html[custom initial page load transaction names].
+
+The RUM Agent can also set the `transaction.name` when observing for transaction events.
+See {apm-rum-ref}/agent-api.html#observe[`apm.observe()`] for more information.
+
+If your problem is occurring in a different Agent, the tips above still apply.
+See the relevant {apm-agents-ref}[Agent API documentation] to adjust how you're naming your transactions.
+
+[float]
+[[troubleshooting-unknown-route]]
 === Unknown route
 
 The {apm-app-ref}/transactions.html[transaction overview] will only display helpful information
@@ -78,6 +143,7 @@ Specifically, view the Agent's supported technologies page.
 You can also use the Agent's public API to manually set a name for the transaction.
 
 [float]
+[[troubleshooting-fields-unsearchable]]
 === Fields are not searchable
 
 In Elasticsearch, index templates are used to define settings and mappings that determine how fields should be analyzed.

src/cli/cluster/cluster_manager.ts

@@ -266,6 +266,11 @@ export class ClusterManager {
       fromRoot('x-pack/plugins/apm/e2e'),
       fromRoot('x-pack/plugins/apm/scripts'),
       fromRoot('x-pack/plugins/canvas/canvas_plugin_src'), // prevents server from restarting twice for Canvas plugin changes,
+      fromRoot('x-pack/plugins/case/server/scripts'),
+      fromRoot('x-pack/plugins/lists/scripts'),
+      fromRoot('x-pack/plugins/lists/server/scripts'),
+      fromRoot('x-pack/plugins/security_solution/scripts'),
+      fromRoot('x-pack/plugins/security_solution/server/lib/detection_engine/scripts'),
       'plugins/java_languageserver',
     ];
 

src/dev/jest/config.js

@@ -43,6 +43,7 @@ export default {
     'src/plugins/**/*.{ts,tsx}',
     '!src/plugins/**/{__test__,__snapshots__,__examples__,mocks,tests}/**/*',
     '!src/plugins/**/*.d.ts',
+    '!src/plugins/**/test_helpers/**',
     'packages/kbn-ui-framework/src/components/**/*.js',
     '!packages/kbn-ui-framework/src/components/index.js',
     '!packages/kbn-ui-framework/src/components/**/*/index.js',
@@ -51,6 +52,7 @@ export default {
     '!packages/kbn-ui-framework/src/services/**/*/index.js',
     'src/legacy/core_plugins/**/*.{js,jsx,ts,tsx}',
     '!src/legacy/core_plugins/**/{__test__,__snapshots__}/**/*',
+    '!src/legacy/core_plugins/tests_bundle/**',
   ],
   moduleNameMapper: {
     '@elastic/eui$': '<rootDir>/node_modules/@elastic/eui/test-env',

x-pack/dev-tools/jest/create_jest_config.js

@@ -44,6 +44,7 @@ export function createJestConfig({ kibanaDirectory, rootDir, xPackKibanaDirector
       '!**/mocks/**',
       '!**/plugins/apm/e2e/**',
       '!**/plugins/siem/cypress/**',
+      '!**/plugins/**/test_helpers/**',
     ],
     coveragePathIgnorePatterns: ['.*\\.d\\.ts'],
     coverageDirectory: `${kibanaDirectory}/target/kibana-coverage/jest`,

x-pack/plugins/infra/common/graphql/types.ts

@@ -329,6 +329,10 @@ export interface UpdateSourceInput {
   logAlias?: string | null;
   /** The field mapping to use for this source */
   fields?: UpdateSourceFieldsInput | null;
+  /** Default view for inventory */
+  inventoryDefaultView?: string | null;
+  /** Default view for Metrics Explorer */
+  metricsExplorerDefaultView?: string | null;
   /** The log columns to display for this source */
   logColumns?: UpdateSourceLogColumnInput[] | null;
 }
@@ -875,6 +879,10 @@ export namespace SourceConfigurationFields {
     fields: Fields;
 
     logColumns: LogColumns[];
+
+    inventoryDefaultView: string;
+
+    metricsExplorerDefaultView: string;
   };
 
   export type Fields = {

x-pack/plugins/infra/common/http_api/source_api.ts

@@ -69,6 +69,8 @@ export const SavedSourceConfigurationRuntimeType = rt.partial({
   description: rt.string,
   metricAlias: rt.string,
   logAlias: rt.string,
+  inventoryDefaultView: rt.string,
+  metricsExplorerDefaultView: rt.string,
   fields: SavedSourceConfigurationFieldsRuntimeType,
   logColumns: rt.array(SavedSourceConfigurationColumnRuntimeType),
 });
@@ -79,14 +81,25 @@ export interface InfraSavedSourceConfiguration
 export const pickSavedSourceConfiguration = (
   value: InfraSourceConfiguration
 ): InfraSavedSourceConfiguration => {
-  const { name, description, metricAlias, logAlias, fields, logColumns } = value;
+  const {
+    name,
+    description,
+    metricAlias,
+    logAlias,
+    fields,
+    inventoryDefaultView,
+    metricsExplorerDefaultView,
+    logColumns,
+  } = value;
   const { container, host, pod, tiebreaker, timestamp } = fields;
 
   return {
     name,
     description,
     metricAlias,
     logAlias,
+    inventoryDefaultView,
+    metricsExplorerDefaultView,
     fields: { container, host, pod, tiebreaker, timestamp },
     logColumns,
   };
@@ -106,6 +119,8 @@ export const StaticSourceConfigurationRuntimeType = rt.partial({
   description: rt.string,
   metricAlias: rt.string,
   logAlias: rt.string,
+  inventoryDefaultView: rt.string,
+  metricsExplorerDefaultView: rt.string,
   fields: StaticSourceConfigurationFieldsRuntimeType,
   logColumns: rt.array(SavedSourceConfigurationColumnRuntimeType),
 });

x-pack/plugins/infra/common/saved_objects/metrics_explorer_view.ts

@@ -55,6 +55,9 @@ export const metricsExplorerViewSavedObjectType: SavedObjectsType = {
           aggregation: {
             type: 'keyword',
           },
+          source: {
+            type: 'keyword',
+          },
         },
       },
       chartOptions: {

x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_chart.test.tsx

@@ -63,6 +63,8 @@ describe('ExpressionChart', () => {
         logColumns: [],
         metricAlias: 'metricbeat-*',
         logAlias: 'filebeat-*',
+        inventoryDefaultView: 'host',
+        metricsExplorerDefaultView: 'host',
         fields: {
           timestamp: '@timestamp',
           message: ['message'],

x-pack/plugins/infra/public/components/saved_views/view_list_flyout.tsx → x-pack/plugins/infra/public/components/saved_views/manage_views_flyout.tsx

@@ -19,17 +19,21 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
-import { SavedView } from '../../hooks/use_saved_view';
+import { SavedView } from '../../containers/saved_view/saved_view';
 
 interface Props<ViewState> {
   views: Array<SavedView<ViewState>>;
   loading: boolean;
+  defaultViewId: string;
+  sourceIsLoading: boolean;
   close(): void;
+  makeDefault(id: string): void;
   setView(viewState: ViewState): void;
   deleteView(id: string): void;
 }
 
 interface DeleteConfimationProps {
+  isDisabled?: boolean;
   confirmedAction(): void;
 }
 const DeleteConfimation = (props: DeleteConfimationProps) => {
@@ -46,6 +50,7 @@ const DeleteConfimation = (props: DeleteConfimationProps) => {
             <FormattedMessage defaultMessage="cancel" id="xpack.infra.waffle.savedViews.cancel" />
           </EuiButtonEmpty>
           <EuiButton
+            disabled={props.isDisabled}
             fill={true}
             iconType="trash"
             color="danger"
@@ -64,13 +69,17 @@ const DeleteConfimation = (props: DeleteConfimationProps) => {
   );
 };
 
-export function SavedViewListFlyout<ViewState>({
+export function SavedViewManageViewsFlyout<ViewState>({
   close,
   views,
+  defaultViewId,
   setView,
+  makeDefault,
   deleteView,
   loading,
+  sourceIsLoading,
 }: Props<ViewState>) {
+  const [inProgressView, setInProgressView] = useState<string | null>(null);
   const renderName = useCallback(
     (name: string, item: SavedView<ViewState>) => (
       <EuiButtonEmpty
@@ -89,6 +98,7 @@ export function SavedViewListFlyout<ViewState>({
     (item: SavedView<ViewState>) => {
       return (
         <DeleteConfimation
+          isDisabled={item.isDefault}
           confirmedAction={() => {
             deleteView(item.id);
           }}
@@ -98,6 +108,25 @@ export function SavedViewListFlyout<ViewState>({
     [deleteView]
   );
 
+  const renderMakeDefaultAction = useCallback(
+    (item: SavedView<ViewState>) => {
+      const isDefault = item.id === defaultViewId;
+      return (
+        <>
+          <EuiButtonEmpty
+            isLoading={inProgressView === item.id && sourceIsLoading}
+            iconType={isDefault ? 'starFilled' : 'starEmpty'}
+            onClick={() => {
+              setInProgressView(item.id);
+              makeDefault(item.id);
+            }}
+          />
+        </>
+      );
+    },
+    [makeDefault, defaultViewId, sourceIsLoading, inProgressView]
+  );
+
   const columns = [
     {
       field: 'name',
@@ -112,7 +141,11 @@ export function SavedViewListFlyout<ViewState>({
       }),
       actions: [
         {
-          available: (item: SavedView<ViewState>) => !item.isDefault,
+          available: () => true,
+          render: renderMakeDefaultAction,
+        },
+        {
+          available: (item: SavedView<ViewState>) => true,
           render: renderDeleteAction,
         },
       ],
@@ -124,7 +157,10 @@ export function SavedViewListFlyout<ViewState>({
       <EuiFlyoutHeader>
         <EuiTitle size="m">
           <h2>
-            <FormattedMessage defaultMessage="Load views" id="xpack.infra.openView.flyoutHeader" />
+            <FormattedMessage
+              defaultMessage="Manage saved views"
+              id="xpack.infra.openView.flyoutHeader"
+            />
           </h2>
         </EuiTitle>
       </EuiFlyoutHeader>